Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta brede #96

Closed
wants to merge 9 commits into from
Closed

Beta brede #96

wants to merge 9 commits into from

Conversation

BredeFK
Copy link
Collaborator

@BredeFK BredeFK commented Apr 3, 2019

Changed from NTNU-Bachelor-Management-System-For-CS-Assignments to CSAMS in project

  • Also added so that new users have to confirm email before being created

New/updated tables

CREATE TABLE `validation`
(
    `id`        int(11)     NOT NULL AUTO_INCREMENT,
    `hash`      varchar(64) NOT NULL,
    `user_id`   int(11)              DEFAULT NULL,
    `valid`     tinyint(1)  NOT NULL DEFAULT 1,
    `timestamp` datetime    NOT NULL,
    PRIMARY KEY (`id`)
);

CREATE TABLE `users_pending`
(
    `id`            int(11)     NOT NULL AUTO_INCREMENT,
    `name`          varchar(64) DEFAULT NULL,
    `email_student` varchar(64) NOT NULL,
    `password`      varchar(64) NOT NULL,
    `validation_id` int(11)     NOT NULL,
    PRIMARY KEY (`id`),
    FOREIGN KEY (`validation_id`) REFERENCES validation (`id`)
);

Copy link
Collaborator

@kongebra kongebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New models are not named descriptive enough

docker-compose.yml Show resolved Hide resolved
webservice/model/user_pending.go Show resolved Hide resolved
webservice/model/validation.go Show resolved Hide resolved
// ForgottenPassRepository struct
type ForgottenPassRepository struct {
// ValidationRepository struct
type ValidationRepository struct {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-descriptive naming

)

// UserPendingRepository struct
type UserPendingRepository struct {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-descriptive naming

)

// ValidationService struct
type ValidationService struct {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-descriptive naming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants