Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSTR: Legacy Overwrite Patch #43

Closed
Oddface opened this issue Jan 3, 2015 · 18 comments
Closed

JSTR: Legacy Overwrite Patch #43

Oddface opened this issue Jan 3, 2015 · 18 comments

Comments

@Oddface
Copy link
Contributor

Oddface commented Jan 3, 2015

I remember there being talk of doing a version of this pack using the Legacy textures as a base, and I would just like to float this idea again. The problem with doing this is obviously the large amount of extra work it would create for a pretty small team. The way to mitigate this would be to simply limit it to the dirt and raw stone textures. It would get us most of the way to the classic John Smith look without splintering the style too much and creating a lot of extra work. The ores would be a sizeable workload, but not insurmountable. There are already these lovely copper and tin ores stuck in the alt texture ghetto.


I would certainly want this as an option and I think a lot of other people would too. What do you guys think?

@goldbattle
Copy link
Contributor

I think this could work. Right now all what I do to compile the packs is apply the https://github.com/John-Smith-Modded/JSTR-Overwrites ontop of the normal vanilla release. I think this could be something that could be worked on a separate branch and worked on.

While this would allow vanilla and modded to look the same, but would take a lot of work to do. Maybe we could hold off till the 1.8.x update? I know the tin/dust redo is still in the works on the Ore-Enhancement branch.

@Oddface
Copy link
Contributor Author

Oddface commented Jan 3, 2015

This Legacy version would still have JSTR overwrites, just not the raw stone, dirt, grass, sand and ores. I don't really know the details of the back-end stuff you do, so I don't know the best way to do this. Is working on this in a branch practical in the long run? Can changes in the JSTR branch be merged into the Legacy branch easily? Could it be done in a separate repository of overwrites?

@goldbattle
Copy link
Contributor

Just doing a separate branch like the ore one works great. Once it is all ready to go, it is as simple as merging it into the master, and recompiling the packs. I would check out my comment #36 (comment) on mass recolors, might help speed things up.

@lesdmark
Copy link
Contributor

lesdmark commented Jan 6, 2015

I think it would be better right now to concentrate on trying to get the regular JSTR finished first. There is still so much to do even to get all the textures in the direwolf20 pack. I am working on blood magic and ic2 at the moment which are both huge.

@Oddface
Copy link
Contributor Author

Oddface commented Jan 6, 2015

Well, I think I'm pretty much done with the essentials. The ores are all done (except Metallurgy) and I'm pretty happy with how they've turned out. Some improvements could still be made, like more variation in the ores, but I think I'll do that at a later date. There are also some minor niggles, like how the nether ores don't quite match up with the surface ores. Other stone types (marble, basalt etc.) do still have that JSTR look, but it still looks fine and I'd rather not mess around with those. Anything big I've missed? Any other naturally spawning blocks that are supposed to look like dirt, stone or sand?

@goldbattle
Copy link
Contributor

I think they all look good. I think a couple of them look a bit like the ore texture was pasted on top, not sure if some shading could solve that. I would create a PR when you think these are all ready. If this is good to go, and other people think this is good, the next download I will remove the JSTR dirt, stone, and stone ore textures from the https://github.com/John-Smith-Modded/JSTR-Overwrites repo, and repatch it on top.

@Oddface
Copy link
Contributor Author

Oddface commented Jan 6, 2015

Please do tell which textures you have concerns with and I'll have a look.

@Oddface
Copy link
Contributor Author

Oddface commented Jan 6, 2015

Oh, and I suggest removing the sand from the overwrites as well.

@goldbattle
Copy link
Contributor

Got it.

Sorry about the response was going to edit my post, but got pulled away. Here are the ores I was going to comment on.

Applied_Energistics_2/assets/appliedenergistics2/textures/blocks/OreQuartzStone.png
orequartzstone
Tinker_Construct/assets/tinker/textures/blocks/ore_aluminum_gravel.png
ore_aluminum_gravel
Tinker_Construct/assets/tinker/textures/blocks/ore_iron_gravel.png
ore_iron_gravel

I feel like the elements are not a part of the texture below. Not sure the best way to fix it with the gravels. I think with the AE2 ore it is just the lack of texture on the actual crystal texture. Just some thoughts, nothing that neeeds to be fixed.

@goldbattle
Copy link
Contributor

Just compiled and uploaded things, check them out before I put them up for main downloads.

Patch:
http://minecraft.curseforge.com/texture-packs/223328-john-smith-modded/files/2225235
Main pack:
http://minecraft.curseforge.com/texture-packs/223328-john-smith-modded/files/2225237

/cc @John-Smith-Modded/texturers @John-Smith-Modded/owners

@Oddface
Copy link
Contributor Author

Oddface commented Jan 22, 2015

Everything seems to work. The name and description could be better, though. Maybe call it the JSTR Legacy Patch and mention the stone, dirt and sand in the description as well.

@goldbattle
Copy link
Contributor

The description will be on the main site, I'll update it with details once
I type something up.

On Thu, Jan 22, 2015 at 3:29 PM, Oddface notifications@github.com wrote:

Everything seems to work. The name and description could be better,
though. Maybe call it the JSTR Legacy Patch and mention the stone, dirt and
sand in the description as well.


Reply to this email directly or view it on GitHub
#43 (comment)
.

Patrick Geneva | Administrator | pgb@soartex.net

@Oddface
Copy link
Contributor Author

Oddface commented Jan 22, 2015

Here's a minor problem I just found.
2015-01-22_21 46 55
There are a few green pixels sticking out from under the grass side overlay, which is noticeable in non-green biomes.

@goldbattle
Copy link
Contributor

Have any idea what is causing it?

@Oddface
Copy link
Contributor Author

Oddface commented Jan 22, 2015

The grayscale grass overlay doesn't quite cover all the green grass on the grass side texture. I'm making a fix as we speak.

@goldbattle
Copy link
Contributor

No rush, I am going to let this sit for a day so others can take a look at it, and give some feedback before we let it go live.

@goldbattle goldbattle changed the title JSTR: Legacy Edition? (Technician's Legacy?) JSTR: Legacy Overwrite Patch Jan 22, 2015
@goldbattle
Copy link
Contributor

It's live. Let me know if any wording on the website should be better. This turned out to be pretty cool.

@Oddface
Copy link
Contributor Author

Oddface commented Jan 26, 2015

Thank you for facilitating this little project. Makes me enjoy the pack a lot more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants