some tests #201
Merged
some tests #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove library call that make R CMD check fail
|
This does not pass the checks as it's not suggesting |
|
Added tests covering the examples for statistical plots. |
separated in several files
|
I don't know why this doesn't pass the tests, it works on my computer with Ubuntu 18.04.5, maybe some changes to this repo were made after my initial PR and break the tests? If so, I don't know how to fix this |
|
Thanks @etiennebacher fro adding much needed tests! |
|
Not too shabby for a start: https://coveralls.io/github/JohnCoene/echarts4r :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #56, here are some tests for the package. I tested all examples of chart types and web GL in the documentation.