Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub thinks Octo files are Roff files #14

Open
tobiasvl opened this issue Nov 26, 2019 · 5 comments
Open

GitHub thinks Octo files are Roff files #14

tobiasvl opened this issue Nov 26, 2019 · 5 comments

Comments

@tobiasvl
Copy link
Contributor

According to GitHub, this repo consists almost entirely of Roff files.

We could consider fixing this by adding Octo support to Linguist, the library that detects languages for GitHub. So if that issue is closed, this one can be closed too.

But if we can't be bothered to do that, this repo should probably override the filetype manually.

@benzammour
Copy link

benzammour commented Oct 6, 2022

As the referenced and this issues are almost 3 years old, I assume adding support to Linguist was not successful?
If so, is it okay if I add a PR that does this manually?

@JohnEarnest
Copy link
Owner

@benzammour OK, I'm fine with that.

It's possible that we stand a better chance getting recognized as a valid file extension today than we did 3 years ago, though. Many more repositories containing Octo programs or tools compatible with Octo assembly language exist now.

@benzammour
Copy link

After doing some research, this is not as trivial as it seems.

Firstly, Octo does not meet the "at least 2000 files per extension indexed in the last year" requirement defined here.
Additionally, as we are not able to override the settings to our own language but are restricted to pre-defined ones, we would only be able to use something like Assembly.

However, this is also not desirable, therefore, this issue cannot be resolved trivially

@JohnEarnest
Copy link
Owner

A different avenue which might at least edge us mildly closer to what we want would be to argue for a curtailment of roff extensions. Last time I investigated, it took claim of an absolutely absurd set of wildcard patterns which I doubt reflect actual usage.

@JohnEarnest
Copy link
Owner

Just to add some concrete statistics to the discussion, and for posterity, searching GitHub by extension for .8o:

https://github.com/search?q=extension%3A8o&type=code

Presently produces 822 results. I took a few wild stabs before running into API rate limits and I didn't find a single result that wasn't Octo assembly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants