Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #33 - cmd2 choices_method #62

Closed
wants to merge 4 commits into from
Closed

Conversation

sudoaza
Copy link

@sudoaza sudoaza commented Apr 21, 2022

Update Katana for changes in cmd2 >= 2.0 (June 2021)

Fixing conflicts from @eljeffeg PR

Update Katana for changes in cmd2 >= 2.0 (June 2021)
@TAnas0
Copy link

TAnas0 commented Apr 22, 2023

@sudoaza I must point out cmd2 version 1.0.1 is referenced in he README too under Known Issues. Does your PR also fix that issue?

@sudoaza
Copy link
Author

sudoaza commented Apr 23, 2023

@TAnas0 sorry, I shouldn't have done the MR from master, this now has lots of other stuff.
But that commit was working fine for me I don't know if there is other setups where it might be broken.

@sudoaza
Copy link
Author

sudoaza commented Apr 23, 2023

Closing, moved to #72

@sudoaza sudoaza closed this Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants