Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for default value to overcome decoding errors when we h… #13

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

LionKing2303
Copy link

@LionKing2303 LionKing2303 commented Jul 1, 2020

Added support for default value to overcome decoding errors when we have missing fields, null fields or key-changed fields.

…ave missing fields, null fields or key-changed fields.

This support is only for decode with string key.
If you like my solution then I'll make it also for AnyDateFormatter.
@LionKing2303
Copy link
Author

Hi John!
I don't understand why the CI check failed, I added 2 tests and they passed.
I hope you can look that up.
I'm so excited to be contributing!!

@LionKing2303
Copy link
Author

Also, my changes were based on my Medium article.
https://medium.com/@LionKing2303/avoid-json-surprises-with-codable-d2f6e2978a2e
I'll be thrilled to know that you read it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant