Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 614 support all features in wasm #615

Merged

Conversation

ktrz
Copy link
Contributor

@ktrz ktrz commented Oct 28, 2022

  • pass all --features to cargo build in build-wasm.sh

fixes #614

* pass all --features to cargo build in build-wasm.sh
@ktrz
Copy link
Contributor Author

ktrz commented Oct 28, 2022

hey @JohnnyMorganz
It turned out to be a simple fix. I've verified locally the example from issue #614

Copy link
Owner

@JohnnyMorganz JohnnyMorganz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you update the changelog?

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Base: 97.65% // Head: 97.65% // No change to project coverage 👍

Coverage data is based on head (060f0e8) compared to base (d681afb).
Patch has no changes to coverable lines.

❗ Current head 060f0e8 differs from pull request most recent head 89221b4. Consider uploading reports for the commit 89221b4 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #615   +/-   ##
=======================================
  Coverage   97.65%   97.65%           
=======================================
  Files          14       14           
  Lines        5585     5585           
=======================================
  Hits         5454     5454           
  Misses        131      131           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ktrz
Copy link
Contributor Author

ktrz commented Oct 28, 2022

sure, updated the changelog

CHANGELOG.md Outdated Show resolved Hide resolved
@JohnnyMorganz JohnnyMorganz merged commit c3136e0 into JohnnyMorganz:main Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Npm package doesn't seem to support Luau syntax
2 participants