Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep type pack parentheses in generic #730

Merged
merged 3 commits into from
Jul 6, 2023

Conversation

JohnnyMorganz
Copy link
Owner

Fixes #729

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8a56233) 97.56% compared to head (67b2517) 97.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #730   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files          16       16           
  Lines        6121     6121           
=======================================
  Hits         5972     5972           
  Misses        149      149           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JohnnyMorganz JohnnyMorganz merged commit 0e2c60d into main Jul 6, 2023
@JohnnyMorganz JohnnyMorganz deleted the parentheses-around-type-pack branch July 6, 2023 10:46
littensy added a commit to littensy/remo that referenced this pull request Jul 8, 2023
remove `nil` from type packs when JohnnyMorganz/StyLua#730 is released in the next StyLua version
littensy added a commit to littensy/remo that referenced this pull request Jul 8, 2023
* feat: use tuples for async return types

* chore: add todo to update type packs

remove `nil` from type packs when JohnnyMorganz/StyLua#730 is released in the next StyLua version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unwanted removal of parenthesis around pack parameters in Luau
1 participant