Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with release-gitter 2.2.0 #808

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

rouge8
Copy link
Contributor

@rouge8 rouge8 commented Oct 31, 2023

Fixes #807

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3c2ac12) 97.58% compared to head (a80a847) 97.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #808   +/-   ##
=======================================
  Coverage   97.58%   97.59%           
=======================================
  Files          16       16           
  Lines        6135     6143    +8     
=======================================
+ Hits         5987     5995    +8     
  Misses        148      148           

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@JohnnyMorganz JohnnyMorganz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look and fixing this!

I don't use the precommit hook myself so I haven't tested this - I'm assuming it works given that you've submitted the patch :)

Note to self: maybe we should have a way to check precommit is working in CI

@JohnnyMorganz JohnnyMorganz merged commit 32c433a into JohnnyMorganz:main Oct 31, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pre-commit setup failure: KeyError: 'git-url'
2 participants