Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write files only if modified #836

Merged
merged 2 commits into from
Dec 23, 2023
Merged

Write files only if modified #836

merged 2 commits into from
Dec 23, 2023

Conversation

JohnnyMorganz
Copy link
Owner

Only write a file if the contents before and after are different.

O(n) check, but I don't think it matters (formatting is still the most expensive part!)

Fixes #827

Copy link

codecov bot commented Dec 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5de9a1d) 97.02% compared to head (453f75e) 97.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #836   +/-   ##
=======================================
  Coverage   97.02%   97.02%           
=======================================
  Files          16       16           
  Lines        5989     5991    +2     
=======================================
+ Hits         5811     5813    +2     
  Misses        178      178           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Repo Comparison Test

No diff produced

@JohnnyMorganz JohnnyMorganz merged commit a5ca6a4 into main Dec 23, 2023
17 of 19 checks passed
@JohnnyMorganz JohnnyMorganz deleted the write-on-modified-only branch December 23, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modification time of unchanged files are changed
1 participant