Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump txtorcon from 23.0.0 to 23.11.0 #1651

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

kristapsk
Copy link
Member

In #1567 we updated to 23.0.0, not 23.5.0, because that was the last version supporting Python 3.7. Now that Python 3.7 support is dropped with #1639, can upgrade to latest.

Changes in 23.5.0:

  • twisted.web.client.Agent instances now use the same HTTPS policy by default as twisted.web.client.Agent. It is possible to override this policy with the tls_context_factory= argument, the equivalent to Agent's contextFactory= (Thanks to Itamar Turner-Trauring)
  • Added support + testing for Python 3.11.
  • No more ipaddress dependency

Changes in 23.11.0:

Basically, not much changes, but fixed bug, dropped dependencies and better support for Python 3.11 and 3.12 is good enough reason to merge for me.

@kristapsk kristapsk added the dependencies Pull requests that update a dependency file label Feb 1, 2024
Copy link
Contributor

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ca33eca

@AdamISZ
Copy link
Member

AdamISZ commented Feb 3, 2024

Test suite passing is good enough here, but may be worth manually checking joinmarketd and particularly payjoin CLI functioning is correct (it's very unlikely in this case, but we do have some monkeypatching of txtorcon in our Tor code that could easily break in an update).

@kristapsk
Copy link
Member Author

Successfully tested payjoin on testnet from JoinMarket to JoinMarket. https://blockstream.info/testnet/tx/c84631c55f55dac1e406ac030c691358d554eb9664f3f6d6edbd5521cca2a7da

@kristapsk kristapsk merged commit 575a7ec into JoinMarket-Org:master Feb 5, 2024
9 checks passed
@kristapsk kristapsk deleted the txtorcon-23.11.0 branch February 5, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants