Fix GH#17796: Export correct system-distance #186
Conversation
Jojo-Schmitz
force-pushed
the
3.x-xmldist
branch
from
9cce5dd
to
62a6639
Compare
importexport/musicxml/exportxml.cpp
Outdated
| @@ -5987,9 +5987,10 @@ void ExportMusicXml::print(const Measure* const m, const int partNr, const int f | |||
|
|
|||
| if (mpc.systemStart && !mpc.pageStart) { | |||
| // see System::layout2() for the factor 2 * score()->spatium() | |||
| const Measure* prevSystem = mpc.prevMeasure->isMMRest() ? mpc.prevMeasure->mmRestFirst() : mpc.prevMeasure; | |||
There was a problem hiding this comment.
@rettinghaus: As Mu3 doesn't have coveringMMRestOrThis(), I'm using your earlier approach here, is that OK?
Interestingly this PR here passes the mtests, but your's doe not?!
There was a problem hiding this comment.
Does it work? My tests didn't, that's why I changed the approach. I'd be grateful if you could help me with that test.
There was a problem hiding this comment.
Well, the tests pass here
Jojo-Schmitz
force-pushed
the
3.x-xmldist
branch
3 times, most recently
from
ec7032d
to
d3ec60c
Compare
|
@rettinghaus mind to check why this doesn't pass the mtest, esp. at https://github.com/Jojo-Schmitz/MuseScore/actions/runs/6372850758/job/17296046686?pr=186#step:5:1702 (the rest seems minor things to manually correct) |
|
That's why I asked you if this approach works for you. It should work, but doesn't, that why I changed it in 4.2.0. |
|
Hmm, yeah, unfortunaltely Mu3 seems to be lacking the infrastructure you're using in your Mu4 PR, that |
Jojo-Schmitz
force-pushed
the
3.x-xmldist
branch
from
d3ec60c
to
4c06ad8
Compare
|
Nonsens, it doesn't, no idea why I couldn't find it initially. Thanks for getting me on track again ;-) |
Jojo-Schmitz
force-pushed
the
3.x-xmldist
branch
3 times, most recently
from
dc33aa1
to
d83853a
Compare
Jojo-Schmitz
force-pushed
the
3.x-xmldist
branch
from
d83853a
to
790199d
Compare
Backport of musescore#19512
Resolves: musescore#17796