Fix GH#22601: Include text alignment in line layout #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That vtest diff isn't OK, before: And with a crecendo line it shows the whole desaster: No idea why the seemingly same code behaves different in Mu3 vs. Mu4 |
Jojo-Schmitz
force-pushed
the
3.x-text-line-alignment
branch
4 times, most recently
from
7814b27
to
8f5893d
Compare
Backport of musescore#22602 Plus some cleanup in the includes
Jojo-Schmitz
force-pushed
the
3.x-text-line-alignment
branch
from
8f5893d
to
14b517e
Compare
|
@XiaoMigros any idea why this doesn't work?`Neither the vtest mentioned above, nor the new one: |
|
Hmm, I can't see why not at a glance... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of musescore#22602
Resolves: musescore#22601