Improve UI testability #125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for the PR! This looks pretty good, but without any concrete tests beyond a PoC this is not something I'd want on master. To be honest I wouldn't add any UI tests myself anytime soon, so unless you are planning on adding more tests I'd go ahead and close this PR. |
|
I'll try to add some tests. Keep the PR open please. |
Added an actual meaning to UI tests, checking all the steps of the Demo swift app
|
Hey @JonasGessner, please have a look at the updated PR. I added a more meaningful UI test for the Swift app. I can add more tests, but it would require to expand the Swift app example with more feature or to test the Obj-C app. If you are not willing to consinder the PR, please at least keep (or add new) accessibilityIdentifier(s) to the HUD views. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be easier to interact with JGProgressHUD during UI tests.
I added a very basic sample Swift UI test project and some basics
accessibilityIdentifierto some relevant things of JGProgressHUD.It's just a basic proof of concept (I'm really not an expert of Objective-C) in order to make you understand the idea, I'm sure there is plenty of space for improvement.