Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create initial version of end points that are compatible with RISE Repo #30

Merged
merged 1 commit into from
Dec 6, 2018

Conversation

gdevanla
Copy link
Contributor

@gdevanla gdevanla commented Dec 5, 2018

The PR addresses the following:

  1. End points required to be compatible with the Rise Repository API has been provided.
  2. Separate end points have been created and does overlap with current end points. Feedback on how to unify these is welcome
  3. The collection UUID is hard-coded to 1.0 since corpus-db does not currently have an notion of collections.

@JonathanReeve I spoke to @pbelouin and have added these changes as a follow up to that conversation. This is a first iteration therefore feel free to provide feedback to streamline this API and make it better.

@JonathanReeve
Copy link
Owner

Looks good to me. Only thing I'd suggest is adding documentation for these points on the docs page. Ideally, there would be a way of automatically generating docs from the Haskell code (haddocs?), but I haven't learned how to do that, yet. I'll merge this now, and recompile the version on the server, as soon as I get a chance to test it, and open an issue for the documentation.

@JonathanReeve JonathanReeve merged commit fd40a72 into JonathanReeve:master Dec 6, 2018
@pbelouin-mpiwg
Copy link

Hi Jonathan and Guru, thanks for this! Some documentation is available here: https://rise.mpiwg-berlin.mpg.de/pages/doc_for_resource_providers
Would this be a good starting point? If so I can probably clean it up and add it somewhere that you would deem appropriate?

@JonathanReeve
Copy link
Owner

JonathanReeve commented Dec 10, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants