Skip to content

Commit

Permalink
test: Drop aux-*-dynamic from pyinstall-aux-static-exec test
Browse files Browse the repository at this point in the history
Bringing along your own extra dynamically-linked executable is not
supported by staticx.

Even the name of this overall test says "static".

See:
#129 (comment)
  • Loading branch information
JonathonReinhart committed Jul 28, 2020
1 parent 39e827b commit cfd7a64
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 9 deletions.
2 changes: 0 additions & 2 deletions test/pyinstall-aux-static-exec/.gitignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
build/
dist/
aux-glibc-dynamic
aux-glibc-static
aux-musl-dynamic
aux-musl-static
4 changes: 2 additions & 2 deletions test/pyinstall-aux-static-exec/auxlist.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This list originally had -dynamic variants, but that is not supported by staticx.
# See https://github.com/JonathonReinhart/staticx/issues/129#issuecomment-657246015
aux_apps = (
'aux-glibc-dynamic',
'aux-glibc-static',
'aux-musl-dynamic',
'aux-musl-static',
)
6 changes: 1 addition & 5 deletions test/pyinstall-aux-static-exec/run_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,10 @@ cd "$(dirname "${BASH_SOURCE[0]}")"

# Build our auxiliary app
echo "Building aux app with gcc"
gcc $CCFLAGS -o aux-glibc-dynamic aux.c
gcc $CCFLAGS_STATIC -o aux-glibc-static aux.c

if [ -x "$(command -v musl-gcc)" ]; then
echo "Building aux app with musl-gcc"
musl-gcc $CCFLAGS -o aux-musl-dynamic aux.c
musl-gcc $CCFLAGS_STATIC -o aux-musl-static aux.c
fi

Expand Down Expand Up @@ -52,7 +50,5 @@ $outfile
# Run it under an old distro
if [ -n "$TEST_DOCKER_IMAGE" ]; then
echo -e "\nRunning staticx executable under $TEST_DOCKER_IMAGE"

# This environment won't have a dynamic musl-libc
scuba --image $TEST_DOCKER_IMAGE $outfile --skip aux-musl-dynamic
scuba --image $TEST_DOCKER_IMAGE $outfile
fi

0 comments on commit cfd7a64

Please sign in to comment.