Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List keys function #12

Merged
merged 16 commits into from
Aug 18, 2023
Merged

List keys function #12

merged 16 commits into from
Aug 18, 2023

Conversation

WilfredAlmeida
Copy link
Contributor

@WilfredAlmeida WilfredAlmeida commented Aug 16, 2023

Related Issues

This is associated with the following issues: #4

Changes proposed

List API keys feature in the SDK.

Checklist (Check all the boxes which are applicable)

  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
    • If yes, I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Signed-off-by: Wilfred Almeida <almeidawilfred642@gmail.com>
Signed-off-by: Wilfred Almeida <almeidawilfred642@gmail.com>
Signed-off-by: Wilfred Almeida <almeidawilfred642@gmail.com>
Signed-off-by: Wilfred Almeida <almeidawilfred642@gmail.com>
Signed-off-by: Wilfred Almeida <almeidawilfred642@gmail.com>
Signed-off-by: Wilfred Almeida <almeidawilfred642@gmail.com>
Signed-off-by: Wilfred Almeida <almeidawilfred642@gmail.com>
Signed-off-by: Wilfred Almeida <almeidawilfred642@gmail.com>
Signed-off-by: Wilfred Almeida <almeidawilfred642@gmail.com>
Signed-off-by: Wilfred Almeida <almeidawilfred642@gmail.com>
@Jonxslays
Copy link
Owner

Just a note before I begin reviewing the code:

You should not merge your PR branch into master on your fork. You should PR the branch into master of the parent repository. It makes pulling down your code to test messier if you do it the way you've done.

Copy link
Owner

@Jonxslays Jonxslays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly documentation updates, and just a small refactor. The feature is working well great job!

src/client.rs Outdated Show resolved Hide resolved
src/client.rs Outdated Show resolved Hide resolved
src/client.rs Outdated Show resolved Hide resolved
src/client.rs Outdated Show resolved Hide resolved
src/client.rs Outdated Show resolved Hide resolved
src/services/apis.rs Show resolved Hide resolved
src/services/apis.rs Show resolved Hide resolved
src/services/apis.rs Show resolved Hide resolved
src/services/apis.rs Outdated Show resolved Hide resolved
src/client.rs Outdated Show resolved Hide resolved
WilfredAlmeida and others added 3 commits August 18, 2023 17:37
Signed-off-by: Wilfred Almeida <almeidawilfred642@gmail.com>
Signed-off-by: Wilfred Almeida <almeidawilfred642@gmail.com>
@WilfredAlmeida
Copy link
Contributor Author

Just a note before I begin reviewing the code:

You should not merge your PR branch into master on your fork. You should PR the branch into master of the parent repository. It makes pulling down your code to test messier if you do it the way you've done.

Thanks for the info. I'll keep this in mind and PR accordingly hence forth.

@WilfredAlmeida
Copy link
Contributor Author

I've implemented the suggested changes. Please take a look. Thanks!

Copy link
Owner

@Jonxslays Jonxslays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few more comments to address, and the failing test is just due to using Response::Error which doesnt exist, instead of Response::Err, which does.

src/client.rs Show resolved Hide resolved
src/models/apis.rs Outdated Show resolved Hide resolved
src/services/apis.rs Show resolved Hide resolved
src/services/apis.rs Outdated Show resolved Hide resolved
src/models/apis.rs Outdated Show resolved Hide resolved
src/models/apis.rs Outdated Show resolved Hide resolved
src/models/apis.rs Outdated Show resolved Hide resolved
src/client.rs Outdated Show resolved Hide resolved
WilfredAlmeida and others added 3 commits August 18, 2023 19:49
Signed-off-by: Wilfred Almeida <almeidawilfred642@gmail.com>
Signed-off-by: Wilfred Almeida <almeidawilfred642@gmail.com>
@Jonxslays Jonxslays merged commit 879f95d into Jonxslays:master Aug 18, 2023
12 checks passed
@Jonxslays Jonxslays mentioned this pull request Aug 18, 2023
@Jonxslays Jonxslays added the enhancement New feature or request label Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants