Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Result in place of Wrapped in the public api #38

Merged
merged 3 commits into from
Jul 20, 2024
Merged

Conversation

Jonxslays
Copy link
Owner

@Jonxslays Jonxslays commented Jul 20, 2024

Summary

Implements From<Wrapped<T>> for Result<T, HttpError>.
Returns Result<T, HttpError> from all service methods, and async client methods.
Wrapped is now internal implementation detail.

Checklist

  • I have run cargo test and all tests pass.
  • I have run cargo fmt and the code is formatted.
  • I have run cargo clippy in pedantic mode and refactored.
  • I have included documentation for any new structs or methods.
  • I have updated tests for any code I addded/changed/deleted.
  • I have updated the CHANGELOG to include my changes.

Related Issues

Resolves #37

@Jonxslays Jonxslays added the enhancement New feature or request label Jul 20, 2024
@Jonxslays Jonxslays changed the title Issue/37/result Update async client methods to return a result Jul 20, 2024
@Jonxslays Jonxslays changed the title Update async client methods to return a result Use Result in place of Wrapped in the public api Jul 20, 2024
@Jonxslays Jonxslays merged commit 58f7b24 into master Jul 20, 2024
12 checks passed
@Jonxslays Jonxslays deleted the issue/37/result branch July 20, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the ? operator cannot be applied to type Wrapped<()>
1 participant