-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculation of the rating #164
Calculation of the rating #164
Conversation
I have tested this item ✅ successfully. |
Testing with Joomla 4.3.4, PHP 8.1.13, mysql 8.0.31. |
I don't think this is relevant, as the evaluation will be done later on the website and not directly in the database. So it will not be possible to award a 6. |
Keep in mind that JG 3 allows a rating up to 10. |
Sorry, I didn't have that in mind. I assumed that 5 is the maximum rate. |
You are right. The value in the configuration is assumed to be the 'limit' for the display. However, this was already the case with JoomGallery 3.6.
This is correct.
That is also correct too. |
Can we merge this PR? |
This PR can merged. The max vote will be add later in the system. |
@MrMusic Can you please resolve the remaining confict? |
Yes, or is there something against this?
Actually, every PR should be tested before it is merged.
Should now be done. |
Thank you very much ✅ |
This PR adds the functionality to calculate and display the rating of an image.
The calculate code was taken from JomGallery 3.6.
The rating is displayed in the backend and frontend at the respective image.
Please note: There is no functionality yet to rate images in the frontend. For testing, the number of ratings (imgvotes) and the rating sum (imgvotesum) must be entered manually into the database table.