Feature/percentage mode #5

athkalia · 2015-09-23T16:31:15Z

Added percentage mode functionality, and updated the sample project with a mini-example

Fix few typos

…illable loaders according to a percentage. Initial commit.

athkalia · 2015-09-23T16:33:13Z

Hey, I am not quite familiar with Github, or gradle or travis :D So give me a shout on anything that needs updating.

Cheers

athkalia · 2015-09-23T16:39:44Z

Travis failed, but this is cause it's trying to compile the sample project against the old version of the library (1.02) that doesn't have the percentage.

How do we handle this ?

JorgeCastilloPrz · 2015-09-24T15:22:08Z

Just change the gradle dependency of the sample project (in your PR) to

compile project(:library)

(remove compile 'com.github.jorgecastilloprz:fillableloaders:1.02@aar' so it does not try to get the dependency from maven central)

athkalia · 2015-09-24T15:32:41Z

Shall I change the version under this commit as well ? from 1.02 to 1.03 ?

…illable loaders according to a percentage. Changed dependency from maven to local for the sampleApp

JorgeCastilloPrz · 2015-09-24T15:33:35Z

Yes, change it to 1.03, please.

…illable loaders according to a percentage. Updated library version.

JorgeCastilloPrz · 2015-09-26T11:31:06Z

Hi. Can you update your branch and pull the new develop changes? I have merged a master commit which had not been merged time ago. Then i will review and test your code.

Thanks in advance!

athkalia · 2015-09-28T16:36:52Z

I think that they are already included, this branch is already up-to-date with develop and master

danvass · 2015-09-29T04:00:52Z

@JorgeCastilloPrz Could you please accept this and push the new version to maven?

JorgeCastilloPrz · 2015-10-01T22:13:15Z

If you want this PR to be merged, i would need:

A new sample page with the new percentage feature added by XML custom attribute.
A real sample of a loading which a percentage being changed along the way of a "mock" download.
Cleaning the code for the setPercentage() method, as it is pretty dirty.
Updating README file properly with the new functionality.

Thanks for your help.

athkalia · 2015-10-07T01:10:15Z

Hey, thanks for your quick review. I'll try to get this done during the coming weekend.

JorgeCastilloPrz · 2015-10-31T10:06:49Z

Hello. Did you work on the last changes we talked about?. Thanks in advance.

athkalia · 2015-10-31T23:22:17Z

hey, sorry for the delay but unfortunately it's gonna get delayed more. I am about to undergo surgery so I doubt this is gonna get looked at for at least a few weeks.

Cheers

Letme · 2016-05-02T14:53:25Z

This seems like it is not moving. Can we move this a bit just to get it merged in?

athkalia · 2016-05-02T18:32:49Z

Hey, I made a pull request a long time ago but unfortunately I don't have any time to spend on this. Please feel free to continue the pull request.

AndroidStudio proposed update of gradle version to keep in sync with latest and greatest.

SeekBar on top of the last fragment enables user to define the percentage *on fly*. It is also a good example of static and functional usage of the setPercentage. Snackbar needed a try-catch as it is throwing an ``` java.lang.NullPointerException: Attempt to invoke virtual method 'void android.widget.TextView.setText(java.lang.CharSequence)' on a null object reference ``` while on InstantRun and I could not be bothered to fix the real reason.

Fill percentage can now also be defined inside the layout as fl_fillPercentage. It is declared as integer, but in case float is really needed then we can change that later on.

Letme · 2016-05-04T08:02:12Z

I have sent PR to athkalia and I hope he can merge it in so this PR gets updated with all requested features except making setPercentage pretty (which I have no idea how).

athkalia · 2016-05-04T08:58:58Z

Thanks mate, I'll have a look during the weekend.

Letme · 2016-05-04T10:02:05Z

I would prefer it sooner, since Jorge will also have to take a look at it.

Feature/percentage mode

athkalia · 2016-05-08T19:11:03Z

Can you have a look at the checkstyle issues please?

Letme · 2016-05-08T19:14:18Z

@athkalia care to add spaces in FillableLoaderPage.java between the brackets on lines 133 and 135 as that is why CI is failing?

athkalia · 2016-05-08T20:18:02Z

It's passing locally for me, same for you @Letme I take it ?

Letme · 2016-05-09T08:08:16Z

Yeah it is passing locally, I checked also the library:lint (which is failing on Travis) and it is executed and passes (finds just 3 errors instead of 4). None of the Lint warnings are produced by changes in this patch (at least on my local build).
@JorgeCastilloPrz can you advise what you want us to do?

Letme · 2016-05-10T21:41:45Z

I do not have any ideas what might be wrong. Can someone help please?

Letme · 2016-05-11T09:33:44Z

One of the differences I spotted is build number of Java (95 on my computer and 76 on Travis). @athkalia can you check yours?

$ javac -J-Xmx32m -version
javac 1.7.0_95
$ java -Xmx32m -version
java version "1.7.0_95"

I could not find any reference on Travis how to fix this.

Since TravisCI produces some lint errors which we cannot reproduce locally and therefor fix, its breakage of build was removed. Since static checker is needed, Coverity was added. Coverity Scan is free for OpenSource projects and much better than lint anyways. It provides a nice outside interface to check for defects and by default it has almost no false positives.

Replace Lint with Coverity to make TravisCI happy

JorgeCastilloPrz · 2016-05-12T13:19:48Z

Thanks for fixing CI :). I will retake this PR this weekend and work on it to get merged. New version will be deployed to maven central pretty soon!.

Thanks for your work guys 👍

Letme · 2016-05-12T13:45:20Z

I hope you do not have to do too much. Still I have set-up the Coverity for my fork of the project and it found 2 defects which I will probably get fixed in near future. I would suggest you set up Coverity as that is much stronger static analysis tool than lint and for opensource it is free (github enables usage as service).

JorgeCastilloPrz · 2016-05-12T18:14:32Z

Please, if you could, it would be nice if you can fix those issues before I
review all the changes and merge your code this weekend.

Thanks in advance!
El 12 may. 2016 3:45 p. m., "Crt Mori" notifications@github.com escribió:

I hope you do not have to do too much. Still I have set-up the Coverity
for my fork of the project and it found 2 defects which I will probably get
fixed in near future. I would suggest you set up Coverity as that is much
stronger static analysis tool than lint and for opensource it is free
(github enables usage as service).

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#5 (comment)

Letme · 2016-05-12T19:24:11Z

I would rather put that on separate PR as this defects are not in scope of this patch.

JorgeCastilloPrz · 2016-05-13T12:55:35Z

Reviewed 2 of 6 files at r2, 1 of 1 files at r4, 11 of 12 files at r5, 1 of 1 files at r6, 3 of 3 files at r7.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

JorgeCastilloPrz and others added 2 commits August 21, 2015 01:19

Merge pull request JorgeCastilloPrz#3 from vbauer/fix-typos

cf55f68

Fix few typos

[feature/percentage_mode]: Added functionality to support partially f…

9444e46

…illable loaders according to a percentage. Initial commit.

athkalia mentioned this pull request Sep 23, 2015

Set the fill level manually #4

Closed

[feature/percentage_mode]: Added functionality to support partially f…

2e0b9aa

…illable loaders according to a percentage. Changed dependency from maven to local for the sampleApp

[feature/percentage_mode]: Added functionality to support partially f…

4b71daf

…illable loaders according to a percentage. Updated library version.

Letme added 4 commits May 3, 2016 09:43

Updated gradle version to 2.1.0

f0341ba

AndroidStudio proposed update of gradle version to keep in sync with latest and greatest.

Adding fill percentage as attribute property

a28a31c

Fill percentage can now also be defined inside the layout as fl_fillPercentage. It is declared as integer, but in case float is really needed then we can change that later on.

README updated with fillPercentage property

a44eaaa

Merge pull request #1 from Letme/feature/percentage_mode

fff62c9

Feature/percentage mode

Fixed minor checkstyle warnings.

3f37558

Making CI happy with style fix

e506239

Letme and others added 2 commits May 12, 2016 10:10

Merge pull request #2 from Letme/feature/percentage_mode

7bb1ff8

Replace Lint with Coverity to make TravisCI happy

JorgeCastilloPrz merged commit b2e12ef into JorgeCastilloPrz:develop May 13, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/percentage mode #5

Feature/percentage mode #5

athkalia commented Sep 23, 2015

athkalia commented Sep 23, 2015

athkalia commented Sep 23, 2015

JorgeCastilloPrz commented Sep 24, 2015

athkalia commented Sep 24, 2015

JorgeCastilloPrz commented Sep 24, 2015

JorgeCastilloPrz commented Sep 26, 2015

athkalia commented Sep 28, 2015

danvass commented Sep 29, 2015

JorgeCastilloPrz commented Oct 1, 2015

athkalia commented Oct 7, 2015

JorgeCastilloPrz commented Oct 31, 2015

athkalia commented Oct 31, 2015

Letme commented May 2, 2016

athkalia commented May 2, 2016

Letme commented May 4, 2016

athkalia commented May 4, 2016

Letme commented May 4, 2016

athkalia commented May 8, 2016

Letme commented May 8, 2016

athkalia commented May 8, 2016

Letme commented May 9, 2016

Letme commented May 10, 2016

Letme commented May 11, 2016

JorgeCastilloPrz commented May 12, 2016

Letme commented May 12, 2016

JorgeCastilloPrz commented May 12, 2016

Letme commented May 12, 2016 via email

JorgeCastilloPrz commented May 13, 2016

Feature/percentage mode #5

Feature/percentage mode #5

Conversation

athkalia commented Sep 23, 2015

athkalia commented Sep 23, 2015

athkalia commented Sep 23, 2015

JorgeCastilloPrz commented Sep 24, 2015

athkalia commented Sep 24, 2015

JorgeCastilloPrz commented Sep 24, 2015

JorgeCastilloPrz commented Sep 26, 2015

athkalia commented Sep 28, 2015

danvass commented Sep 29, 2015

JorgeCastilloPrz commented Oct 1, 2015

athkalia commented Oct 7, 2015

JorgeCastilloPrz commented Oct 31, 2015

athkalia commented Oct 31, 2015

Letme commented May 2, 2016

athkalia commented May 2, 2016

Letme commented May 4, 2016

athkalia commented May 4, 2016

Letme commented May 4, 2016

athkalia commented May 8, 2016

Letme commented May 8, 2016

athkalia commented May 8, 2016

Letme commented May 9, 2016

Letme commented May 10, 2016

Letme commented May 11, 2016

JorgeCastilloPrz commented May 12, 2016

Letme commented May 12, 2016

JorgeCastilloPrz commented May 12, 2016

Letme commented May 12, 2016 via email

JorgeCastilloPrz commented May 13, 2016