UiModal: close on backdrop click only if backdrop also got mousedown
#497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… got the mousedown event
JosephusPaye
requested changes
May 8, 2020
Co-authored-by: Josephus Paye II <j.paye96@gmail.com>
Co-authored-by: Josephus Paye II <j.paye96@gmail.com>
Co-authored-by: Josephus Paye II <j.paye96@gmail.com>
Sure, sounds good! |
|
Thanks for the update, will merge for the next release. |
fabrodz
approved these changes
Apr 29, 2021
JosephusPaye
approved these changes
Dec 31, 2021
JosephusPaye
changed the title
mousedown
|
Thanks! |
|
Released in v1.3.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… got the mousedown event
Currently, users selecting text within the modal and releasing the mouse outside the modal are surprised that the modal closes.