Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make popover support shadow DOM #518

Merged
merged 2 commits into from
Dec 31, 2021
Merged

Make popover support shadow DOM #518

merged 2 commits into from
Dec 31, 2021

Conversation

kilobyte2007
Copy link
Contributor

When using Keen-UI components in the shadow DOM, we need the popovers to be appended only to the root node of the Shadow DOM.

JosephusPaye
JosephusPaye requested changes Jan 26, 2021
View reviewed changes
Copy link
Owner

@JosephusPaye JosephusPaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one request.

src/UiPopover.vue Show resolved Hide resolved
@kilobyte2007 kilobyte2007 reopened this Feb 23, 2021
@kilobyte2007
Copy link
Contributor Author

Hey @JosephusPaye, can you please merge this?

@JosephusPaye JosephusPaye changed the title Make popover support shadow dom Make popover support shadow DOM Dec 31, 2021
@JosephusPaye JosephusPaye merged commit 4e7f6d2 into JosephusPaye:next Dec 31, 2021
@JosephusPaye
Copy link
Owner

Thanks! Released in v1.3.2

@kilobyte2007 kilobyte2007 deleted the shadowdom branch January 10, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosephusPaye JosephusPaye JosephusPaye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kilobyte2007 @JosephusPaye