Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make map viewport resize for interactive maps #13

Merged
merged 9 commits into from
Jul 15, 2017
Merged

Conversation

Josh-ES
Copy link
Owner

@Josh-ES Josh-ES commented Jul 14, 2017

There was previously a conditional in place where only non-interactive maps would resize their viewport when the window was resized. This was because static maps would not be centred correctly if the viewport was not resized. However, interactive maps were not introducing new map tiles when the window was resized, resulting in situations where the window is expanded, leaving blank tiles around the map.

This pull request adds an onAllLoad method to the cache code, which fires a passed callback when all scripts in the script map are loaded. It also fixes a deprecated use of gulp-typescript in the gulp file. Finally, it ensures that all maps have their viewports resized on window resize events.

Closes #8

@coveralls
Copy link

coveralls commented Jul 15, 2017

Coverage Status

Coverage decreased (-2.4%) to 94.85% when pulling 9010d16 on feature/resize into c364b8d on master.

@coveralls
Copy link

coveralls commented Jul 15, 2017

Coverage Status

Coverage increased (+0.2%) to 97.479% when pulling 58c012c on feature/resize into c364b8d on master.

@Josh-ES Josh-ES merged commit f2936b2 into master Jul 15, 2017
@Josh-ES Josh-ES deleted the feature/resize branch July 15, 2017 13:47
tonyraoul pushed a commit to tonyraoul/react-here-maps that referenced this pull request May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resizing is not working when interactive
2 participants