Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grand Theft Auto: San Andreas has graphics and gameplay issues #270

Closed
4 tasks done
CartoonFan opened this issue Jul 28, 2019 · 36 comments
Closed
4 tasks done

Grand Theft Auto: San Andreas has graphics and gameplay issues #270

CartoonFan opened this issue Jul 28, 2019 · 36 comments

Comments

@CartoonFan
Copy link

CartoonFan commented Jul 28, 2019

Please describe your issue as accurately as possible. If you run into a problem with a binary release, make sure to test with latest master as well.

Important: When reporting an issue with a specific game or application, such as crashes or rendering issues, please include log files and a D3D11 Apitrace (see https://github.com/apitrace/apitrace) so that the issue can be reproduced. In order to create a trace, run wine apitrace.exe trace -a dxgi YOURGAME.exe. DO NOT use DXVK together with apitrace!

Software information

Grand Theft Auto San Andreas (Steam 12120)

System information

  • GPU: Nvidia GTX 960
  • Driver: 430.34.0
  • Wine version: 4.12.1 TKG
  • DXVK version: bc64e8e

Apitrace file(s)

https://drive.google.com/file/d/1PmN6V0aXpUYCKG14GS2BCpL5_4ZrwcYi/view?usp=sharing

Motion blur and first mission lockup trace:
https://drive.google.com/file/d/1ADG7IdhmrCxUgb3KRIMg9icgnZkkmgwt/view?usp=sharing

Log files

Hello! I've noticed a weird bug where most vehicles are colored beige up close, but regain their color when viewed at a distance. Some environmental elements are also affected (walls, lights, etc.) It doesn't seem to affect people or motorcycles.

Thanks!

EDIT: Replaced the trace with a tar.xz.

EDIT 2:

Here's a summary of what's been seen so far:

  • Lighting issues

  • Car texture coloring

  • Motion blur

  • First mission freeze

I added another trace which includes motion blur and the first mission gameplay. Cheats were used to obtain a fast car with nitrous, but shouldn't affect anything else.

@NerosTie
Copy link

The game has also a lighting issue.

with d9vk
20190728225330_1

without d9vk
20190728225523_1

@tannisroot
Copy link

^ That's because D9VK is lacking fixed function lightning implementation.

@Guy1524
Copy link
Contributor

Guy1524 commented Aug 9, 2019

To avoid spam I'm just going to report here that the "motion blur" when traveling fast on vehicles is broken on d9vk

@tannisroot
Copy link

Master has ff lightning now so please retest.

@CartoonFan
Copy link
Author

CartoonFan commented Aug 10, 2019

Lighting looks like it's fixed, texture problems still present.

@tannisroot
Copy link

tannisroot commented Aug 10, 2019

texture problems still present.

would be nice to get some screenshots of that mb?

@CartoonFan
Copy link
Author

Alright, I'll get a screenshot of that soon.

@NerosTie
Copy link

NerosTie commented Aug 10, 2019

Cars when they are close:
20190810212322_1

When they are far:
20190810212343_1

@CartoonFan
Copy link
Author

Ha, beat me to it.

Also, there's this weird case in the intro where the car texture is blue instead:

GTASA-20190810-122505

Also, I haven't been able to get through the first mission; The game seems to lock up when starting it and my computer slows to a crawl, requiring me to kill the process.

@CartoonFan
Copy link
Author

CartoonFan commented Aug 12, 2019

@Guy1524 , this is the closest I could get to showing motion blur. Admittedly, I probably wasn't traveling at the same speed both times, but I can't really tell the difference between native and d9vk here. Could you post a screenshot or something else that shows the motion blur issue? It'd be really appreciated. Thanks!

D9VK:
20190811-140818

Native:
20190811221554_1

@CartoonFan
Copy link
Author

All right, I added a second trace which hopefully highlights these issues.

@CartoonFan CartoonFan changed the title Grand Theft Auto: San Andreas has improper vehicle colors up close Grand Theft Auto: San Andreas has graphics and gameplay issues Aug 16, 2019
@NorbertHarangozo
Copy link

Starting from 3831767, CJ and all the NPCs look like this:
gta_sa

gta_sa_d3d9.log

I tried making an apitrace, but it doesn't show the issue.

@NerosTie
Copy link

I can confirm.

With #716 the game was perfect.

@CartoonFan
Copy link
Author

I've got the same thing here. Also, the fullscreen game window is only using the top-left corner for me instead of the whole screen, but I don't know if that's D9VK's issue (it didn't happen with previous commits).

@misyltoad
Copy link
Owner

Can't replicate the fog issue on any of my GTA SA traces

@misyltoad
Copy link
Owner

Can you make a trace with d9vk?

@Riesi
Copy link
Contributor

Riesi commented Aug 22, 2019

d9vk trace that showed the issue for me on replay:
https://drive.google.com/open?id=1Zg2BgHB8yeh9dFggJXFa7qvqqKOAJTmT

@Guy1524
Copy link
Contributor

Guy1524 commented Aug 22, 2019

@CartoonFan The issue actually only happened on my first session playing, the motion blur was offset by about 50% of the screen. However now I can no longer reproduce it, so it's probably best to just ignore it unless somebody re-encounters it.

@CartoonFan
Copy link
Author

@Guy1524 Sounds good to me. I'll update the main post accordingly. Thanks for replying!

@CartoonFan
Copy link
Author

CartoonFan commented Aug 23, 2019

The fog issue looks like it's fixed for me as of 625bf30 . Great job! I also noticed that with the first mission issue, the audio continues to play while the video stays at the mission title, and the audio is fairly quiet compared to what I remember.

With my resolution issue, this is supposedly 1024x768 fullscreen, according to the game:
20190822-165956

The game renders it as seen, black borders and all.

EDIT: It looks like the resolution thing has something to do with the 418.52.20 Vulkan dev drivers. I tried the game again after switching to the 430.40.0 drivers and it works normally. Never mind that, the issue's still there. A similar thing's shown up on at least one other game I've tried recently, so it doesn't seem game-specific either.

@CartoonFan
Copy link
Author

So, a small update:

  • The resolutions are still weird for me. I might try a widescreen patch in the future to make my native resolution available, if nothing else (It's not available at all, probably a fault of the game).

  • The video freezing on the first mission (and consequently the audio issues) seem to be related to anti-aliasing. Turning it off allows me to progress further.

@NerosTie
Copy link

On my side, with #778, everything is good. But yes, the game freezes when there is a transition to a cutscene when the antialiasing is on (could it be related to #264 (comment) ?)

@CartoonFan
Copy link
Author

Awesome! I managed to get my resolution fixed for now by disabling the proton fullscreen patch on Wine-TKG 4.13+. I'm pretty sure it worked before, but maybe something happened. Who knows? I'm just happy to find a workaround.

@NerosTie
Copy link

I don't have any issue with the resolution with Proton, it's weird, but I don't think it's related to d9vk.

@CartoonFan
Copy link
Author

I agree, at least for now. With wined3d, it's like a borderless window, and with d9vk, those black borders are there. That's pretty much the only difference I can see. Virtually every time I changed resolution, I got an effect similar to #270 (comment), even with a clean prefix (+d9vk/dxvk), changing settings, etc. Right now, disabling the fullscreen patch is the only thing so far that has worked almost every time. But I'm definitely glad to hear that it works well for you.

@misyltoad
Copy link
Owner

I have a fix hopefully in the works for this.

@misyltoad
Copy link
Owner

Can you try with 8490b27?

@CartoonFan
Copy link
Author

All right, I'll give it a try.

@CartoonFan
Copy link
Author

Great work! The fullscreen issue seems to be fixed for me with both games I had problems with (this one and Forgotten Realms: Demon Stone). On another note, it's still amazing that I can make a game like this hang indefinitely simply by changing resolutions too often, but as usual, I'm not sure if that's a D9VK bug yet or not. More testing, right? Again, though, stellar job!

@NerosTie
Copy link

NerosTie commented Aug 24, 2019

Forgotten Realms: Demon Stone

Btw, if you have time, can you upload an apitrace for this game? (issue with the logo and the white textures)

@CartoonFan
Copy link
Author

CartoonFan commented Aug 24, 2019

Forgotten Realms: Demon Stone

Btw, if you have time, can you upload an apitrace for this game? (issue with the logo and the white textures)

Yeah, I noticed that too. I have a Windows trace already, but the issues don't show up there, so I just want to make one with D9VK and then I'll be ready. Also, I didn't notice an issue with the logo, just the HUD, textures, and loading screens. Once the bug is up, though, feel free to add anything I missed. Thanks!

@misyltoad
Copy link
Owner

Can this be closed?

@CartoonFan
Copy link
Author

CartoonFan commented Aug 25, 2019

What should I do about the antialiasing-related hang? Should I make a separate bug, or close this and wait for #264, or something else? I'm OK with closing it if the remaining stuff is handled in another bug.

@NerosTie NerosTie mentioned this issue Aug 25, 2019
@Riesi
Copy link
Contributor

Riesi commented Aug 25, 2019

@CartoonFan could you try #328 and see if it fixes the hang?

@CartoonFan
Copy link
Author

All right, I'll try it.

@CartoonFan
Copy link
Author

OK, It seems that the game no longer hangs during cutscenes. There are a few stutters for me near the beginning of the game, but those seem to go away eventually. However, the game seems to be ignoring Wine-TKG's Proton fullscreen patch and changing my desktop resolution when I change it in-game. Do you happen to know anything about this? I can open a separate bug if you think it's not related.

In any case, I guess it's time to close this bug, as the original issues are fixed and my problems here are smaller and more specific.

Closing #270.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants