-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Silent disconnect from lobby #15
Comments
The core issue here is that the server --> lobby architecture is designed to be asynchronous, and we can't expect data from the server at any given time. Therefore we cannot currently detect idle connection failure (we can tell when a request/send fails, but those instances are minimized to reduce server load). That said, there may be some XmPP way to better detect disconnection that we aren't yet using. |
… Might help #15 as well (this bug was probably causing the bot to overload with the thousands of game reports at game end).
I haven't heard further reports, so I'm tentatively closing this. |
Still happens with long games. |
After having been on the lobby more with the release, I've found you can
|
This should be entirely fixed now after adding keep-alive pings and periodically waking up gloox during a game. |
I had been connected to the lobby for a while, at some point I was disconnected (nobody could see me there and I couldn't see them come and go), but I received no notice. I thought I was still connected, so at the least it should detect this and disconnect me (preferably attempt a few reconnects if possible).
The text was updated successfully, but these errors were encountered: