Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Re-run command suggestion includes unnecessary --access public #1127

Closed
3 tasks done
JoshuaKGoldberg opened this issue Dec 29, 2023 · 1 comment · Fixed by #1307
Closed
3 tasks done

🐛 Bug: Re-run command suggestion includes unnecessary --access public #1127

JoshuaKGoldberg opened this issue Dec 29, 2023 · 1 comment · Fixed by #1307
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

I ran npx create-typescript-app --mode create --base everything and filled in all the options. At the end, it should have suggested a re-run command that:

  • Included --base everything and --mode create
  • Filled in values I provided in the prompt...
  • ...and not values implied by --base everything or --mode create

Actual

This was the suggestion it printed:

●  Tip: to run again with the same input values, use: npx create-typescript-app --mode create --base everything --access public --description "Hooray. Delete." --directory delete-me-please --email-github git@joshuakgoldberg.com --email-npm npm@joshuakgoldberg.com --mode create --owner JoshuaKGoldberg --repository delete-me-please --title "Delete Me Please"

Note the --access public. That's the default value for --access. There's no need to redundantly print it. Bug!

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Dec 29, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Feb 15, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Feb 15, 2024
@JoshuaKGoldberg
fix: omit default --access value in rerun suggestions (#1307)
150bce6 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1127
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Adds a `defaultValues` map and filters out key/value pairs matched in
it.
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.57.5 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: omit default --access value in rerun suggestions JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg