-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: debugging in vs code #1153
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1153 +/- ##
==========================================
+ Coverage 94.69% 94.71% +0.02%
==========================================
Files 102 102
Lines 5689 5719 +30
Branches 468 475 +7
==========================================
+ Hits 5387 5417 +30
Misses 301 301
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I can see the migration test is failing: https://github.com/JoshuaKGoldberg/create-typescript-app/actions/runs/7365793330/job/20047430315?pr=1153
I've looked but don't see anything: I've read and re-read https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/DEVELOPMENT.md#the-migration-script but I'm a little lost as to how to update the snapshots. Is there a command to execute I'm missing? |
Yeah sorry, planning on documenting that soon: #1141. #1141 (comment) in the meantime for my personal workflow. And #1153 (comment) is the specific issue here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried this out locally and it works, yay! But, questions on the design 🙂
I'm a little at a loss as to what this error is asking me to do.
Looking here: https://github.com/JoshuaKGoldberg/create-typescript-app/tree/debug-code/src/migrate I don't see a |
I do not like you |
Is there any more to do on this PR @JoshuaKGoldberg? Don't make me send you a 🎂😆 |
D'oh, sorry! No cake needed (not that I'd say no to free food, of course). Just missed the notification. Looking now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup this looks great, thanks! 🚀
Looks like the .github/DEVELOPMENT.md
changes got merged out. But that's ok, we can take them on as a followup. They'll need to be dynamically constructed based on whether options.bin
is provided.
Edit: #1217
🎉 This is included in version v1.54.0 🎉 The release is available on: Cheers! 📦🚀 |
PR Checklist
status: accepting prs
Overview
This PR enables debugging by adding a
tasks.json
and the below configuration to the
launch.json
:Here's an example of debugging using it: