🚀 Feature: Add explicit sizing for README.md logo, if provided #1203
Labels
status: accepting prs
Please, send a pull request to resolve this!
type: feature
New enhancement or request
Bug Report Checklist
main
branch of the repository.Overview
This repository makes use of the
--logo
option from #851 + #1166:create-typescript-app/README.md
Line 18 in e388ba2
But, note how there's no explicit image
height
orwidth
attribute in there. That means the page won't know how to account for the image's size until it loads in. Kind of a performance issue.In JoshuaKGoldberg/all-contributors-auto-action#188 I added a logo to the
all-contributors-auto-action
repository that does have explicitheight
andwidth
attributes. Let's add in explicitheight
andwidth
to this template too!Additional Info
The logo image is created here:
create-typescript-app/src/steps/writeReadme/generateTopContent.ts
Line 64 in e388ba2
However, I think this feature shouldn't assume a 128px by 128px image. It should:
The text was updated successfully, but these errors were encountered: