Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Add ability to remove theme preference #131

Closed
3 tasks done
JoshuaKGoldberg opened this issue Dec 7, 2023 · 0 comments · Fixed by #132
Closed
3 tasks done

🚀 Feature: Add ability to remove theme preference #131

JoshuaKGoldberg opened this issue Dec 7, 2023 · 0 comments · Fixed by #132
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Right now (as of #103), if you click the theme toggle in the header, it sets a localStorage preference for your theme:

dot-com/src/components/ThemeToggle.astro

Line 11 in 6e02671

localStorage.setItem("theme", current);

...but that means as you change your system color then the site will not update. What happens if a user wants to clear their setting?

Let's add a "clear" kind of button next to the theme toggle when it's set. That way folks can localStorage.removeItem the setting.

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! labels Dec 7, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Dec 7, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 7, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add theme clearing button JoshuaKGoldberg/dot-com
1 participant
@JoshuaKGoldberg