Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠 Tooling: Missing tsc script in CI #95

Closed
3 tasks done
JoshuaKGoldberg opened this issue Nov 2, 2023 · 2 comments · Fixed by #96
Closed
3 tasks done

🛠 Tooling: Missing tsc script in CI #95

JoshuaKGoldberg opened this issue Nov 2, 2023 · 2 comments · Fixed by #96
Assignees
Labels
area: tooling status: accepting prs Please, send a pull request to resolve this!

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

This repo lints, formats, etc. in CI but doesn't run tsc! So right now on main there are type checking errors:

$ pnpm tsc

> joshuakgoldberg-dot-com-next@0.0.1 tsc /Users/josh/repos/dot-com
> tsc

src/components/ContentEntry.tsx:2:15 - error TS1484: 'JSX' is a type and must be imported using a type-only import when 'verbatimModuleSyntax' is enabled.

2 import { For, JSX } from "solid-js";
                ~~~

src/components/GroupedEntries.tsx:1:15 - error TS1484: 'JSX' is a type and must be imported using a type-only import when 'verbatimModuleSyntax' is enabled.

1 import { For, JSX } from "solid-js";
                ~~~

src/components/Text.tsx:2:10 - error TS1484: 'JSX' is a type and must be imported using a type-only import when 'verbatimModuleSyntax' is enabled.

2 import { JSX, splitProps } from "solid-js";
           ~~~


Found 3 errors in 3 files.

Errors  Files
     1  src/components/ContentEntry.tsx:2
     1  src/components/GroupedEntries.tsx:1
     1  src/components/Text.tsx:2

Additional Info

No response

@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! area: tooling labels Nov 2, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Nov 2, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Nov 2, 2023
3 tasks
@JoshuaKGoldberg
Copy link
Owner Author

@all-contributors please add @JoshuaKGoldberg for tool.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

Copy link
Contributor

@JoshuaKGoldberg

We had trouble processing your request. Please try again later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tooling status: accepting prs Please, send a pull request to resolve this!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant