feat: Astro View Transitions #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JoshuaKGoldberg
changed the title
JoshuaKGoldberg
commented
Aug 1, 2023
| @@ -29,7 +29,7 @@ | |||
| "@kobalte/core": "^0.9.6", | |||
| "@typescript-eslint/eslint-plugin": "^5.59.9", | |||
| "@typescript-eslint/parser": "^5.59.9", | |||
| "astro": "^2.6.2", | |||
| "astro": "^2.9.7", | |||
There was a problem hiding this comment.
Note that the pnpm-lock.yaml file in this PR contains a bunch of unrelated changes from me running pnpm dedupe and updating Astro to the latest version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Uses the most minimal usage of https://docs.astro.build/en/guides/view-transitions to get all pages to fade between each other.
I'm very impressed with how straightforward this was. The diff count is really more like
+7🟩-0, with two of those additions just being blank lines. I also happened to bump theastropackage version in this PR.I'd initially wanted to only fade a few elements (header, hero images) at first - but pending withastro/roadmap#633 I don't see a good way to do that.