-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Don't require version if package has "private": true
#84
Comments
BTW the README for this project mentions an option to pick which spec to use, with "npm" being the default. Where is the npm package.json spec? I can't find it. |
👍 from me on this. The npm docs in https://docs.npmjs.com/cli/v10/configuring-npm/package-json#version say:
Ignoring whether skipping the name is ok even if it's optional, skipping version seems like a straightforward "yes". Thanks for filing! |
I don't believe there's a spec more specific than what's linked in the README: docs.npmjs.com. I've never seen one at any rate. |
FWIW I went back to having a version of "0.0.0" in my private packages because pnpm won't publish packages that have dev dependencies on private packages without a version, for some reason. I was also able to get changesets to ignore these private, versioned packages so I'm a happy camper. (pnpm/pnpm#5094) I still think this feature request is a good idea for this package, so I'm not closing the issue. Just thought I'd call out that I'm not clamoring for it. |
Published in |
While it is valid for a private package (
"private": true
) to have a version, it certainly shouldn't require one.Tools like changeset require that you remove the private package version number (instead of, say providing a useless one like 0.0.1) or it will try to manage that version, even if the package is private. Ideally this package would just allow no versions on private packages.
(Moving the discussion from JoshuaKGoldberg/eslint-plugin-package-json#250 to here)
The text was updated successfully, but these errors were encountered: