Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: Indicate errors to the user, if possible #2

Open
3 tasks done
JoshuaKGoldberg opened this issue Aug 26, 2022 · 3 comments
Open
3 tasks done

🚀 Feature: Indicate errors to the user, if possible #2

JoshuaKGoldberg opened this issue Aug 26, 2022 · 3 comments
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

Feature Request Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Any errors should be presented to the user, if possible.

  1. If a repository's .github/replies.yml can't be loaded, then a little indication should be shown in the Saved Replies dropdown
  2. If that dropdown can't be found on a page where it's expected to be, then a console.error should mention it

Additional Info

Right now, if a network request fails to load repository data as expected, a console.error logs the response... and that's about it.

@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! good first issue Good for newcomers, please hop on! labels Aug 26, 2022
@gpuligundla
Copy link

Hi, can i work on this?

@JoshuaKGoldberg
Copy link
Owner Author

Heya @gpuligundla, thanks for asking! I don't use any kind of issue claiming system: https://github.com/JoshuaKGoldberg/refined-saved-replies/blob/1c0f731d3575788f95d0f64bca5b346f3a0957a2/.github/CONTRIBUTING.md#issue-claiming. If you've got code changes you'd like to send in for review then please do.

I'd suggest reading through those contributing docs and the development docs linked to in them. They'll answer a lot of common questions about getting started and contributing.

For this issue in particular, I'm not too picky on the visualization of the complaint. So if you're not sure whether something is right, then go ahead and send it and we can always take a look 😄.

@gpuligundla
Copy link

I'm very sorry for not completely reading the CONTRIBUTING.md.
I'll open PR with a fix Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Development

No branches or pull requests

2 participants