Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: At least one dependency name should be specified for removal after --mode initialization #724

Closed
3 tasks done
JoshuaKGoldberg opened this issue Aug 29, 2023 · 1 comment · Fixed by #727
Closed
3 tasks done
Assignees
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Aug 29, 2023

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

After fixing #722, we should pass with no errors.

Actual

Error: Failed uninstalling initialization-only packages
    at withSpinner (file:///Users/josh/repos/template-typescript-node-package/lib/shared/cli/spinners.js:16:11)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async initializeWithOptions (file:///Users/josh/repos/template-typescript-node-package/lib/initialize/initializeWithOptions.js:47:5)
    ... 2 lines matching cause stack trace ...
    at async Object.initialize (file:///Users/josh/repos/template-typescript-node-package/lib/initialize/index.js:9:10)
    at async bin (file:///Users/josh/repos/template-typescript-node-package/lib/bin/index.js:47:10)
    at async file:///Users/josh/repos/template-typescript-node-package/bin/index.js:4:20 {
  [cause]: Error: Command failed with exit code 1: pnpm remove
   ERR_PNPM_MUST_REMOVE_SOMETHING  At least one dependency name should be specified for removal
      at makeError (file:///Users/josh/repos/template-typescript-node-package/node_modules/.pnpm/execa@8.0.1/node_modules/execa/lib/error.js:60:11)
      at handlePromise (file:///Users/josh/repos/template-typescript-node-package/node_modules/.pnpm/execa@8.0.1/node_modules/execa/index.js:124:26)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
      at async removeDependencies (file:///Users/josh/repos/template-typescript-node-package/lib/shared/packages.js:9:3)
      at async uninstallPackages (file:///Users/josh/repos/template-typescript-node-package/lib/steps/uninstallPackages.js:9:3)
      at async withSpinner (file:///Users/josh/repos/template-typescript-node-package/lib/shared/cli/spinners.js:11:20)
      at async initializeWithOptions (file:///Users/josh/repos/template-typescript-node-package/lib/initialize/initializeWithOptions.js:47:5)
      at async run (file:///Users/josh/repos/template-typescript-node-package/lib/initialize/index.js:11:7)
      at async runOrRestore (file:///Users/josh/repos/template-typescript-node-package/lib/shared/runOrRestore.js:7:5)
      at async Object.initialize (file:///Users/josh/repos/template-typescript-node-package/lib/initialize/index.js:9:10) {
    shortMessage: 'Command failed with exit code 1: pnpm remove',
    command: 'pnpm remove',
    escapedCommand: 'pnpm remove',
    exitCode: 1,
    signal: undefined,
    signalDescription: undefined,
    stdout: ' ERR_PNPM_MUST_REMOVE_SOMETHING  At least one dependency name should be specified for removal',
    stderr: '',
    cwd: '/Users/josh/repos/temp/testing-cta-6',
    failed: true,
    timedOut: false,
    isCanceled: false,
    killed: false
  }
}

Additional Info

😂 it never ends...

@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Aug 29, 2023
@JoshuaKGoldberg JoshuaKGoldberg added this to the Ready to Rename milestone Aug 29, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Aug 29, 2023
JoshuaKGoldberg added a commit that referenced this issue Aug 29, 2023
<!-- 👋 Hi, thanks for sending a PR to template-typescript-node-package!
💖.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

- [x] Addresses an existing open issue: fixes #724
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/template-typescript-node-package/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Refactors the two existing package removal functions to be just one.
@github-actions
Copy link

🎉 This is included in version v1.29.13 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant