Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't pnpm remove an empty list of packages #727

Merged
merged 5 commits into from
Aug 29, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

Refactors the two existing package removal functions to be just one.

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #727 (53247a5) into main (2b3d05a) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #727      +/-   ##
==========================================
- Coverage   91.12%   91.10%   -0.03%     
==========================================
  Files          82       82              
  Lines        4000     3990      -10     
  Branches      221      223       +2     
==========================================
- Hits         3645     3635      -10     
  Misses        354      354              
  Partials        1        1              
Flag Coverage Δ
create 72.78% <16.66%> (+0.03%) ⬆️
initialize 33.50% <83.33%> (-0.20%) ⬇️
migrate 72.88% <16.66%> (+0.03%) ⬆️
unit 36.02% <72.22%> (+0.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/shared/packages.ts 100.00% <100.00%> (ø)
src/steps/finalizeDependencies.ts 100.00% <100.00%> (ø)
src/steps/uninstallPackages.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JoshuaKGoldberg JoshuaKGoldberg merged commit 5127bcb into main Aug 29, 2023
16 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the safe-package-removals branch August 29, 2023 20:24
@github-actions
Copy link

🎉 This is included in version v1.29.13 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: At least one dependency name should be specified for removal after --mode initialization
1 participant