Fix orion requests issue in video ending view #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdembler
reviewed
Jul 22, 2021
src/api/hooks/video.ts
Outdated
| @@ -52,3 +55,15 @@ export const useAddVideoView = (opts?: AddVideoViewOpts) => { | |||
| ...rest, | |||
| } | |||
| } | |||
|
|
|||
| type VideosWithBasicInformationOpts = QueryHookOptions<GetVideosWithBasicInformationQuery> | |||
| export const useVideosWithBasicInformation = ( | |||
There was a problem hiding this comment.
Maybe just useBasicVideos? We already use a similar name - useBasicChannel
src/api/queries/videos.graphql
Outdated
| @@ -11,6 +11,16 @@ fragment LicenseFields on License { | |||
| customText | |||
| } | |||
|
|
|||
| fragment VideoBasicFields on Video { | |||
There was a problem hiding this comment.
Likewise, we currently use BasicChannelFields
kdembler
approved these changes
Jul 22, 2021
drillprop
added a commit
that referenced
this pull request
Jul 22, 2021
* fix issue with redundant orion requests * cr fixes
drillprop
added a commit
that referenced
this pull request
Jul 23, 2021
* fix issue with redundant orion requests * cr fixes
drillprop
added a commit
that referenced
this pull request
Jul 26, 2021
* fix issue with redundant orion requests * cr fixes
kdembler
pushed a commit
that referenced
this pull request
Jul 28, 2021
* fix issue with redundant orion requests * cr fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.