Giza. Add storage buckets bag assignments. #3088
Conversation
- add "assigned_bags" field
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/joystream/pioneer-testnet/EPacZXTgPzab2oFbruWnFUevBqL7 [Deployment for 708bb07 canceled] |
shamil-gadelshin
added
bug
yarn.lock
Outdated
| @@ -3142,7 +3142,7 @@ | |||
| lodash "^4.17.15" | |||
| moment "^2.24.0" | |||
|
|
|||
| "@joystream/warthog@2.41.2", "@joystream/warthog@~2.41.2": | |||
| "@joystream/warthog@2.41.2", "@joystream/warthog@^2.40.0": | |||
There was a problem hiding this comment.
this change doesn't seem correct. When I ran yarn build:packages in your branch it reverted to:
"@joystream/warthog@2.41.2", "@joystream/warthog@~2.41.2":
There was a problem hiding this comment.
perhaps you are not using the same version of yarn. (which may be the case if you haven't installed volta)
There was a problem hiding this comment.
$ yarn --version
1.22.15
$ volta --version
1.0.5
|
Implementation looks correct. |
Crates: - storage - runtime - node - chain-spec-builder
Updated the yarn.lock file with command: yarn build:packages
| Self::change_bag_assignments(&BTreeSet::new(), &deleted_dynamic_bag.distributed_by); | ||
| Self::change_bag_assignments_for_distribution_buckets( | ||
| &BTreeSet::new(), | ||
| &deleted_dynamic_bag.distributed_by, |
There was a problem hiding this comment.
Should we, perhaps in a future iteration, add commitment in extrinsic to this length, as in principle this set could be different to what caller thinks, for the purposes of weight function? Same for stored_by, below.
If you agree, please make new issues for this with correct labels, in particular storage-pallet, runtime and mainnet.
We need to fix a bug in the storage pallet: storage buckets deletion doesn't change the bag.
Changes
Storage pallet changes
assigned_bagfield to theStorageBucketdelete_storage_bucketdelete_dynamic_bagcreate_dynamic_bag