Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli v0.9.0 #4468

Merged
merged 3 commits into from
Nov 28, 2022
Merged

cli v0.9.0 #4468

merged 3 commits into from
Nov 28, 2022

Conversation

mnaamani
Copy link
Member

@mnaamani mnaamani commented Nov 26, 2022

We forgot to bump cli version for carthage release.

There seems to be an issue however running some commands that use the "chalk" module.

bin/run account:info
    Error: Must use import to load ES Module: /Users/mokhtar/tmp/package/node_modules/chalk/source/index.js
    require() of ES modules is not supported.
    require() of /Users/mokhtar/tmp/package/node_modules/chalk/source/index.js from 
    /Users/mokhtar/tmp/package/lib/base/DefaultCommandBase.js is an ES module file as it is a .js file whose nearest parent 
    package.json contains "type": "module" which defines all .js files in that package scope as ES modules.
    Instead rename index.js to end in .cjs, change the requiring code to use import(), or remove "type": "module" from 
    /Users/mokhtar/tmp/package/node_modules/chalk/package.json.

    Code: ERR_REQUIRE_ESM

To reproduce, npm pack the cli, extract then run npm install in extracted location, finally run with ./bin/run account:info or bin/run api:getUri

@vercel
Copy link

vercel bot commented Nov 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
pioneer-testnet ⬜️ Ignored (Inspect) Nov 28, 2022 at 1:15PM (UTC)

@Lezek123
Copy link
Contributor

There seems to be an issue however running some commands that use the "chalk" module.

chalk was updated in https://github.com/Joystream/joystream/pull/3803/files#diff-088b5e0ac52dd36816ebc6b121d5423c763c3c18c098b91757c014937c7d632d to a version that is not compatible with commonjs build target.

The changelog can be seen here: https://github.com/chalk/chalk/releases

Reverted to 4.1.2 in mnaamani#17

@mnaamani
Copy link
Member Author

There seems to be an issue however running some commands that use the "chalk" module.

chalk was updated in https://github.com/Joystream/joystream/pull/3803/files#diff-088b5e0ac52dd36816ebc6b121d5423c763c3c18c098b91757c014937c7d632d to a version that is not compatible with commonjs build target.

The changelog can be seen here: https://github.com/chalk/chalk/releases

Reverted to 4.1.2 in mnaamani#17

Thanks for the quick fix. Merged and published https://www.npmjs.com/package/@joystream/cli/v/0.9.0

@mnaamani mnaamani merged commit 3629e16 into Joystream:master Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants