Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Nara] make tests dependent of block production time to not run on "fast production" runtime #4945

Merged
merged 1 commit into from
Oct 24, 2023
Merged

[Nara] make tests dependent of block production time to not run on "fast production" runtime #4945

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions runtime/src/constants.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,8 @@ mod tests {
assert!(0 < transfer_fee && transfer_fee < CENTS);
}

// This test does not make sense for `testing-runtime`, because of 1s blocks
#[cfg(not(feature = "testing-runtime"))]
// This test does not make sense for `fast-block-production`, because of 1s blocks
#[cfg(not(feature = "fast-block-production"))]
#[test]
// This test verifies that the cost of filling blocks with max. normal dispatch extrinsics
// total weight for 1 day is within the pre-determined bounds
Expand Down Expand Up @@ -222,8 +222,8 @@ mod tests {
assert!(day_of_full_blocks_cost <= BLOCK_WEIGHT_FILL_MAX_DAILY_COST);
}

// This test does not make sense for `testing-runtime`, because of 1s blocks
#[cfg(not(feature = "testing-runtime"))]
// This test does not make sense for `fast-block-productione`, because of 1s blocks
#[cfg(not(feature = "fast-block-production"))]
#[test]
// This test verifies that the cost of filling blocks with max. normal dispatch extrinsics
// total length for 1 day is within the pre-determined bounds
Expand Down