-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metaprotocol labeling: mappings and protobufs #4987
Open
mkbeefcake
wants to merge
11
commits into
Joystream:master
Choose a base branch
from
mkbeefcake:feature/label_tag
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkbeefcake
force-pushed
the
feature/label_tag
branch
from
December 5, 2023 02:58
d1ab8be
to
a021915
Compare
mkbeefcake
force-pushed
the
feature/label_tag
branch
from
December 5, 2023 05:26
a021915
to
a968439
Compare
kdembler
requested changes
Dec 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @mkbeefcake, sorry for a late look at this. Left some comments, hope we can get back to this and move quickly! 🚀
kdembler
changed the title
added protobuf and mappings
metaprotocol labeling: mappings and protobufs
Jan 5, 2024
kdembler
requested changes
Jan 10, 2024
kdembler
reviewed
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created Protobuf type and mapping handler in query-node for Label
For the issue #4830