-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Luxor finishing touches #5130
Luxor finishing touches #5130
Conversation
Colossus/uptime feat
…oad_aborted_error [Colossus] fix: upload aborted error
Nara master update
Upgrade to Nara
@polkadot/api bump to v10.7.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart the weights since I don't know much about them
|
||
// INFO: https://nodejs.org/dist/latest-v18.x/docs/api/http.html#serverrequesttimeout | ||
// Set the server request timeout to 0 to disable it. This was default behaviour pre Node.js 18.x | ||
server.requestTimeout = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't expected this change in this PR but I guess it's expected right @mnaamani ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason we see it here, is because I've included updates from master branch. Because I know QA testing will happen from the luxor branch so best for it to also have what will ultimately be the proper version used for all the apps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's because the PR includes updates from master - 8ab3a43
@joystream/types
v4.5.0