Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Luxor finishing touches #5130

Conversation

mnaamani
Copy link
Member

@mnaamani mnaamani commented Apr 8, 2024

  • Re-locate new dispatch calls to the end so not to change call index of existing dispatches
  • Code cleanup (removal TODO comments)
  • Update metadata and types, @joystream/types v4.5.0
  • Update from master
  • Update generated weights for council, project-token and proposals-codex pallets.

@mnaamani mnaamani marked this pull request as ready for review April 8, 2024 13:40
Copy link
Member

@kdembler kdembler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart the weights since I don't know much about them


// INFO: https://nodejs.org/dist/latest-v18.x/docs/api/http.html#serverrequesttimeout
// Set the server request timeout to 0 to disable it. This was default behaviour pre Node.js 18.x
server.requestTimeout = 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't expected this change in this PR but I guess it's expected right @mnaamani ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason we see it here, is because I've included updates from master branch. Because I know QA testing will happen from the luxor branch so best for it to also have what will ultimately be the proper version used for all the apps.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's because the PR includes updates from master - 8ab3a43

@mnaamani mnaamani changed the title Luxor preserve dispatch indices weights cleanup Luxor finishing touches Apr 8, 2024
@mnaamani mnaamani merged commit 5974a9b into Joystream:luxor Apr 8, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants