Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New way to generate commitment and algorithm switch #66

Merged
merged 3 commits into from
Feb 14, 2023

Conversation

WRadoslaw
Copy link
Contributor

No description provided.

Copy link
Contributor

@Lezek123 Lezek123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/config.ts Outdated Show resolved Hide resolved
Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com>
@attemka attemka merged commit acd9cbf into Joystream:app-actions Feb 14, 2023
attemka added a commit that referenced this pull request Feb 24, 2023
* add support for AppAction signatures (#51)

fixes #50

* New way to generate commitment and algorithm switch (#66)

* New way to generate commitment and algorithm switch

* Comment update

* Update secret key comments

Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com>

---------

Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com>

---------

Co-authored-by: WRadoslaw <92513933+WRadoslaw@users.noreply.github.com>
Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com>
Lezek123 added a commit that referenced this pull request Mar 30, 2023
* App-actions functionality (#75)

* add support for AppAction signatures (#51)

fixes #50

* New way to generate commitment and algorithm switch (#66)

* New way to generate commitment and algorithm switch

* Comment update

* Update secret key comments

Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com>

---------

Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com>

---------

Co-authored-by: WRadoslaw <92513933+WRadoslaw@users.noreply.github.com>
Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com>

* Update app action commitment, disallow signing arbitrary appActionMetadata (#81)

* Update app action commitment, disallow signing arbitrary appActionMetadata

* Linter fix

* Update `generateAppActionCommitment` impl. (#85)

---------

Co-authored-by: attemka <attemka@gmail.com>
Co-authored-by: WRadoslaw <92513933+WRadoslaw@users.noreply.github.com>
Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com>
ignazio-bovo pushed a commit to ignazio-bovo/orion that referenced this pull request Jul 3, 2023
* add support for AppAction signatures (Joystream#51)

fixes Joystream#50

* New way to generate commitment and algorithm switch (Joystream#66)

* New way to generate commitment and algorithm switch

* Comment update

* Update secret key comments

Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com>

---------

Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com>

---------

Co-authored-by: WRadoslaw <92513933+WRadoslaw@users.noreply.github.com>
Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com>
ignazio-bovo pushed a commit to ignazio-bovo/orion that referenced this pull request Jul 3, 2023
* App-actions functionality (Joystream#75)

* add support for AppAction signatures (Joystream#51)

fixes Joystream#50

* New way to generate commitment and algorithm switch (Joystream#66)

* New way to generate commitment and algorithm switch

* Comment update

* Update secret key comments

Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com>

---------

Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com>

---------

Co-authored-by: WRadoslaw <92513933+WRadoslaw@users.noreply.github.com>
Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com>

* Update app action commitment, disallow signing arbitrary appActionMetadata (Joystream#81)

* Update app action commitment, disallow signing arbitrary appActionMetadata

* Linter fix

* Update `generateAppActionCommitment` impl. (Joystream#85)

---------

Co-authored-by: attemka <attemka@gmail.com>
Co-authored-by: WRadoslaw <92513933+WRadoslaw@users.noreply.github.com>
Co-authored-by: l1.media <31551045+traumschule@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants