Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪛 Do not create 2 WalletConnect instances #4787

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Conversation

thesan
Copy link
Member

@thesan thesan commented Feb 23, 2024

That's a small detail since only the constructor would be called twice the first instance is garbage collected.

Copy link

vercel bot commented Feb 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dao ✅ Ready (Inspect) Visit Preview Feb 23, 2024 10:29am
pioneer-2 ✅ Ready (Inspect) Visit Preview Feb 23, 2024 10:29am
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Feb 23, 2024 10:29am

@thesan thesan merged commit 18c0fc2 into dev Feb 23, 2024
7 checks passed
@thesan thesan deleted the fix/walletconnect-instance branch February 23, 2024 11:15
@thesan thesan changed the title 🪛 Do not create to WalletConnect instances 🪛 Do not create 2 WalletConnect instances Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant