Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose NotFound json errors #404

Merged

Conversation

stokarenko
Copy link
Contributor

Exposes the JSON API error if it comes as a part of NotFound response - similar to the other error classes.
Keeping the backward support for sure.

@stokarenko
Copy link
Contributor Author

Hey there @gaorlov )

Very tiny improvement please )

Copy link
Collaborator

@gaorlov gaorlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! thanks for contributing!
Please merge in main to get tests running in the PR
Thanks!

@gaorlov gaorlov merged commit a07145a into JsonApiClient:master Jun 5, 2023
@gaorlov
Copy link
Collaborator

gaorlov commented Jun 5, 2023

1.21.1 is now live. Thanks for your work and patience!

@stengineering0
Copy link

hey, thanks a lot! )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants