Upgrade style app #414

JuanVqz · 2023-08-25T00:47:21Z

Remove bulma and sprockets config
Replace js and style tag helpers
Add ViteRails, trix editor, fontawesome
Disable specs temporarily

codeclimate

The PR diff size of 7830 lines exceeds the maximum allowed for the inline comments feature.

- [x] Remove simple_form bulma, and update simple_form initializer

Links: - https://vite-ruby.netlify.app/guide/plugins.html - https://github.com/ElMassimo/vite_ruby/tree/main/vite-plugin-rails

codeclimate

The PR diff size of 9694 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 9825 lines exceeds the maximum allowed for the inline comments feature.

Big thanks to https://flowbite.com gh repo clone themesberg/flowbite-admin-dashboard Links: - https://github.com/themesberg/flowbite - https://tailwindcss.com/

codeclimate

The PR diff size of 9845 lines exceeds the maximum allowed for the inline comments feature.

Big thanks to https://flowbite.com gh repo clone themesberg/flowbite-admin-dashboard Links: - https://github.com/themesberg/flowbite - https://tailwindcss.com/

codeclimate

The PR diff size of 10971 lines exceeds the maximum allowed for the inline comments feature.

I'll remove duplication

codeclimate

The PR diff size of 13957 lines exceeds the maximum allowed for the inline comments feature.

* Use Node.js v20 * Update Node.js CI

codeclimate

The PR diff size of 14411 lines exceeds the maximum allowed for the inline comments feature.

* Install stimulus * Add mi frist stimulus controller: resize_field_controller I hope I did a good pattern here

```ruby NoMethodError: undefined method `feature' for RSpec::ExampleGroups::MedicalConsultationsFlow:Class ./spec/system/appoinments_spec.rb:8:in `block in <top (required)>' ./spec/system/appoinments_spec.rb:3:in `<top (required)>' ```

codeclimate

The PR diff size of 14503 lines exceeds the maximum allowed for the inline comments feature.

* Some improvements * Move search.js to focus field stimulus controller

codeclimate

The PR diff size of 14517 lines exceeds the maximum allowed for the inline comments feature.

I'm really enjoying working with Stimulus. It's a great way to add interactivity to a Rails app without having to write a lot of custom JS.

codeclimate

The PR diff size of 14518 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 14537 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 14537 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 14570 lines exceeds the maximum allowed for the inline comments feature.

We should include multiple: true when is a has many relationship = f.input :files, input_html: { multiple: true }

codeclimate

The PR diff size of 14589 lines exceeds the maximum allowed for the inline comments feature.

* Update i18n views * hospitalizations * update patient_referral * Updapte i18n referred_doctor

JuanVqz · 2024-02-24T15:13:18Z

Fix months later but today is the day that will merge at the end of the day, flag day was magically chosen 😅

JuanVqz · 2024-02-24T15:25:56Z

app/models/bento.rb

@@ -1,6 +1,6 @@
 class Bento < ApplicationRecord
  belongs_to :patient

-  validates :code, presence: true
+  validates :code, :patient, presence: true


Remove model

And remove table

JuanVqz · 2024-02-24T15:26:08Z

app/models/doctor.rb

@@ -1,7 +1,6 @@
 class Doctor < User
  belongs_to :hospital
  has_and_belongs_to_many :patients, join_table: "doctors_patients"
-  has_many :medical_consultations


Remove table

JuanVqz · 2024-02-24T15:30:20Z

app/views/appoinments/index.html.haml

-  %table.table.is-hoverable.is-fullwidth
-    %thead.is-uppercase
+= render 'shared/section' do
+  %div.flex.flex-col.md:flex-row.md:justify-between


Suggested change

%div.flex.flex-col.md:flex-row.md:justify-between

.flex.flex-col.md:flex-row.md:justify-between

JuanVqz · 2024-02-24T15:39:29Z

app/views/hospitals/_form.html.haml

@@ -27,6 +27,6 @@
  .buttons
    = link_to :back, class: "button is-link" do
      %span.icon
-        %i.fa.fa-arrow-left
+        %span.fa.fa-arrow-left
      %span Regresar


Will update it to use i18n

JuanVqz · 2024-02-24T15:40:34Z

app/views/hospitals/edit.html.haml

-      %span.is-uppercase Actualizar presentación de la página
+= render "shared/section" do
+  %div.flex.flex-col.md:flex-row.md:justify-between
+    = link_to "Regresar", :patients


JuanVqz · 2024-02-24T15:43:03Z

app/views/layouts/partials/_navbar.html.haml

-    #navMenu.navbar-menu
-      .navbar-end
+%nav.fixed.z-30.w-full.border-b.border-gray-300.dark:border-gray-700.bg-gray-100.dark:bg-gray-800
+  %div.px-3.py-3.lg:px-5.lg:pl-3


Suggested change

%div.px-3.py-3.lg:px-5.lg:pl-3

.px-3.py-3.lg:px-5.lg:pl-3

JuanVqz · 2024-02-24T15:45:27Z

app/views/patient_referrals/index.html.haml

-          %i.fa.fa-plus
-        %span Registrar Referencia de Paciente
+= render 'shared/section' do
+  %div.flex.flex-col.md:flex-row.md:justify-between


Suggested change

%div.flex.flex-col.md:flex-row.md:justify-between

.flex.flex-col.md:flex-row.md:justify-between

JuanVqz · 2024-02-24T15:48:46Z

app/views/patients/_clinic_history.html.haml

-  .column.is-4
-    %strong= t("activerecord.attributes.patient.other_background")
-    %p= @patient.other_background
+= render "shared/title", title: t('.title')


is this view used?

Suggested change

= render "shared/title", title: t('.title')

= render 'shared/title', title: t('.title')

yes, it is used.

JuanVqz · 2024-02-24T15:50:05Z

app/views/patients/index.html.haml

-  %table.table.is-hoverable.is-fullwidth
-    %thead.is-uppercase
+= render 'shared/section' do
+  %div.flex.flex-col.md:flex-row.md:justify-between


Suggested change

%div.flex.flex-col.md:flex-row.md:justify-between

.flex.flex-col.md:flex-row.md:justify-between

JuanVqz · 2024-02-24T15:51:20Z

app/views/referred_doctors/index.html.haml

-          %i.fa.fa-plus
-        %span Registrar Doctor
+= render 'shared/section' do
+  %div.flex.flex-col.md:flex-row.md:justify-between


Suggested change

%div.flex.flex-col.md:flex-row.md:justify-between

.flex.flex-col.md:flex-row.md:justify-between

codeclimate

The PR diff size of 14780 lines exceeds the maximum allowed for the inline comments feature.

codeclimate · 2024-02-24T21:29:57Z

Code Climate has analyzed commit 3443a98 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 90.3% (1.0% change).

View more on Code Climate.

JuanVqz changed the title ~~Upgrade app~~ Upgrade style app Aug 25, 2023

JuanVqz self-assigned this Aug 25, 2023

codeclimate bot reviewed Aug 25, 2023

View reviewed changes

JuanVqz force-pushed the upgrade-to-tailwindcss branch 2 times, most recently from 7637b5e to 5ad6db1 Compare August 25, 2023 05:26

JuanVqz added 5 commits August 24, 2023 23:30

Remove bulma and sprockets config

38c586c

- [x] Remove simple_form bulma, and update simple_form initializer

Add ViteRails, trix editor, fontawesome

d42570d

Links: - https://vite-ruby.netlify.app/guide/plugins.html - https://github.com/ElMassimo/vite_ruby/tree/main/vite-plugin-rails

Replace js and style tag helpers

310b7bc

Disable specs temporarily

0220de3

Install tailwind and config

4920b02

JuanVqz force-pushed the upgrade-to-tailwindcss branch from 5ad6db1 to 4920b02 Compare August 25, 2023 05:30

codeclimate bot reviewed Aug 25, 2023

View reviewed changes

codeclimate bot reviewed Aug 26, 2023

View reviewed changes

Add tailwind template

4801a48

Big thanks to https://flowbite.com gh repo clone themesberg/flowbite-admin-dashboard Links: - https://github.com/themesberg/flowbite - https://tailwindcss.com/

JuanVqz force-pushed the upgrade-to-tailwindcss branch from 0cbb10d to 4801a48 Compare August 27, 2023 06:07

codeclimate bot reviewed Aug 27, 2023

View reviewed changes

JuanVqz added 3 commits August 27, 2023 02:50

Add tailwind template

ce578b9

Big thanks to https://flowbite.com gh repo clone themesberg/flowbite-admin-dashboard Links: - https://github.com/themesberg/flowbite - https://tailwindcss.com/

Add model table

ab85a72

Remove spec views

4538e13

codeclimate bot reviewed Aug 28, 2023

View reviewed changes

JuanVqz added 10 commits September 3, 2023 01:49

Watch files that include tailwind

7c93a1c

Use block at the views

445a2ec

Update locales

a1343f1

I'll remove duplication

Update simple_form input style

7dacca3

Update date field

0510f00

Translate model at form buttons

89ca6d2

Match button style

32ef6ee

Fix: Scope patients per hospital

0b57637

Scope patients list per hospital

82bbb4e

Validate patient_id at appoinment save

26bc589

Remove unused code

3d3df7b