This repository has been archived by the owner on Jun 27, 2022. It is now read-only.
New PersonItem component. #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Vallejoanderson
commented
Mar 15, 2022
•
Vallejoanderson
commented
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/juanvqz/swapi/2hWx8qTF4Zd4aV5Tzcf4PGUqrjw4 |
Vallejoanderson
force-pushed
the
personitem
branch
from
76f51bf
to
22117e1
Compare
davbrito
suggested changes
Mar 15, 2022
|
somos señores no seniors 🤣 |
🤣🤣🤣 |
|
@Vallejoanderson cuando tengas oportunidad estaría bueno que corrijas los comentarios que David hizo, por fas, para darle merge 👍 |
Co-authored-by: David Brito <39559632+davbrito@users.noreply.github.com>
|
Creo que ya quedaron aprobados todos los cambios gente, muchas gracias por la paciencia! 🙌 |
|
@Vallejoanderson Ahora el linter se esta quejando, podrías arreglarlo por favor |
|
Es por el prettier. Tienes que formatear los archivos que editaste |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.