-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with UIStackView #23
Comments
Hi @robinkunde, sorry for the delay in the answer. I've checked this behaviour and you're right, it's a bug. So, I'm going to add this bug in the backlog and I'm going to try to fix as soon as possible. |
I am also having this issue. Are there any updates? |
@jmjordan my workaround for |
One workaround is to wrap your labels in a UIView. It's subpar (I'm seeing #64 with this approach), but it gets you most of the way there. |
I've worked around this issue by not setting the text to nil but setting it to " " instead. PrepareForSkeletonProtocol.swift:17
|
Submitted a pull request to fix this. |
Could you check if this bug is solved? |
Sorry, I'm not using SkeletonView at the moment, but I looked at the diff at that should take care of it. You can close the issue if that works for you. |
What did you do?
I have a UIStackView that contains several labels. I called showSkeleton() on all the labels.
What did you expect to happen?
Each label shows up skeletonized.
What happened instead?
Because SkeletonView sets the text of each label to nil, UIStackView sets the height of each label to 0 and lays them out on top of each other.
SkeletonView Environment
SkeletonView version:
1.0.4
Xcode version:
9.2
Swift version:
4
The text was updated successfully, but these errors were encountered: