-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash when pushing view controller with date picker on top of view controller with skeleton started and stopped #259
Comments
Note: The viewController with skeletonable views has a table view and its cells are skeletonable |
Hi @minaMagedNaeem, version 1.8.6 is ready to use. This version has a change related to trait collection changes, but I don't know if it will solve this issue. Could you check it? Thanks |
No, The issue is still happening |
Sorry, I can’t reproduce this issue. Could you provide an example with the code with which you are getting this crash, please? |
Skeleton view version: 1.8.6 |
Hai, I experienced the same thing on iOS 12 @Juanpe . After I tracked it, this happened in version 1.8.3. Thanks |
Hello, |
I am also facing same issue with DatePicker. Application is crashing with same logs.
|
The best solution for now used version 1.8.2 @byMohamedali |
Thank you @bagusandinata, The bug seems to append on iOS 12.3.1, it's working fine on iOS 12.2 |
Also experienced the same in our app, unfortunately released into the wild :( Stacktrace below if it helps Fatal Exception: NSRangeException |
I'm sorry its out of the issue context, but when I try installing 1.8.2 using this line |
I figured it out, the line has to be |
I am also facing same issue with DatePicker. Application is crashing. |
pod 'SkeletonView', '1.8.2' |
@Juanpe the bug exists on ios simulator 12.2 some of the stack trace are following,
|
Fix Issue #259: Prevent isSkeletonActive to be called when isSkeletonable is false
That PR fixed the issue for me. |
I have downgraded to 1.8.2 but the crash still exist |
Also experiencing this crash, and tried versions 1.8.2-1.8.6 to resolve. Steps to reproduce were similar: pushing date picker after skeleton view was already in view hierarchy. After some investigation the crash occurs in |
@trekirkman The fix was merged to master, but not released. It is not in 1.8.6. I configured cocoapods to use the git URL as source rather than the version number tag. Not sure what's holding up a minor/patch bump. |
Hi all, version 1.8.7 has been released :) sorry for the delay |
can confirm 1.8.7 fixes crash |
I am having this issue as well on 1.8.6. Will try updating to 1.8.7 |
the crash not existing on 1.8.7 |
nop 1.8.2 to 1.8.7 still happening 1.8.1 is not happening I'm using iOS 11 (iOS 13 crash is not there for all versions tried 1.8.2- 1.8.3 - 1.8.6 - 1.8.7) 2020-07-01 18:47:56.323559+0100 Baims Stagging[34181:1043055] *** Terminating app due to uncaught exception 'NSRangeException', reason: '*** -[__NSArrayM objectAtIndex:]: index 2 beyond bounds [0 .. 1]' |
Same crash for iOS 12.4 (iOS 13+ is fine). Tried 1.9.0 version |
Possible workaround: vladyslavsosiuk@b7bf390 |
Hi guys, I noticed that this issue is solved in the latest version (1.23.0). You can check it using the provided sample project. Simulator.Screen.Recording.-.iPhone.8.Plus.-.2021-08-19.at.11.48.05.mp4I'm going to close this issue. Feel free to reopen it :) |
What did you do?
tried to push a view controller with a DatePickerView with mode set to .time when there was a view controller with skeletonable views in the navigation controller stack
What did you expect to happen?
The view controller will be pushed and I will be able to see the DatePickerView
What happened instead?
The app crashed on appDelegate start
Call Stack
Steps to reproduce the behavior
Note: it works on ios13 but crashes on lower than ios13
SkeletonView Environment
SkeletonView version: 1.8.5
Xcode version: 11.3.1
Swift version: Swift 5
The text was updated successfully, but these errors were encountered: