Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default composites #87

Merged
merged 5 commits into from
Aug 10, 2022
Merged

Add default composites #87

merged 5 commits into from
Aug 10, 2022

Conversation

adrhill
Copy link
Member

@adrhill adrhill commented Aug 9, 2022

Closes #85.

Adds default composites

  • EpsilonGammaBox
  • EpsilonPlus
  • EpsilonAlpha2Beta1
  • EpsilonPlusFlat
  • EpsilonAlpha2Beta1Flat

Refactors composites from #84 by

  • renaming RuleMap to TypeRule
  • adding FirstLayerTypeRule and LastLayerTypeRule

* rename `RuleMap` to `TypeRule`
* add `FirstLayerTypeRule` and `LastLayerTypeRule`
fix accidentally uncommented non-composite testsets
@codecov-commenter
Copy link

Codecov Report

Merging #87 (df74013) into master (526a5b7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   95.05%   95.04%   -0.01%     
==========================================
  Files          15       15              
  Lines         485      505      +20     
==========================================
+ Hits          461      480      +19     
- Misses         24       25       +1     
Impacted Files Coverage Δ
src/lrp/lrp.jl 96.42% <ø> (ø)
src/lrp/composite.jl 100.00% <100.00%> (+2.22%) ⬆️
src/lrp/show.jl 100.00% <100.00%> (ø)
src/compat.jl 0.00% <0.00%> (-25.00%) ⬇️
src/lrp/rules.jl 96.46% <0.00%> (-0.10%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@adrhill adrhill merged commit ac52d64 into master Aug 10, 2022
@adrhill adrhill deleted the ah/default-composites branch August 10, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add default composites
2 participants