Make TextHeatmaps and VisionHeatmaps strong dependencies #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and call TextHeatmaps using explicit `textheatmap` instead of dispatching on `heatmap`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
==========================================
- Coverage 98.18% 98.00% -0.19%
==========================================
Files 7 5 -2
Lines 55 50 -5
==========================================
- Hits 54 49 -5
Misses 1 1 ☔ View full report in Codecov by Sentry. |
adrhill
added a commit
that referenced
this pull request
Nov 17, 2023
Merged
adrhill
added a commit
that referenced
this pull request
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...instead of previous weak dependencies.
Instead of dispatching everything on
heatmap, nowheatmapcalls VisionHeatmaps.jltextheatmapcalls TextHeatmaps.jlThis PR therefore requires a breaking release.
Edit: breaking changes undone in #6